[Bug 24242] New: Funds with no library assigned do not appear on edit suggestions page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Bug ID: 24242 Summary: Funds with no library assigned do not appear on edit suggestions page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org bug 18743 made $branchfilter use the logged in user branch by default, however, branchfilter is also used in the call to GetBudgets, now funds with no library associated do not appear in the dropdown when editing suggestions or in the 'Acquisition information' filters To recreate: 1 - Create a new fund with no library in an active budget 2 - Browse to Acquisitions->Suggestions 3 - Click 'Acquisition information' to expand the filters 4 - The fund does not appear 5 - Edit a suggestion 6 - Cannot set fund to your new fund, it does not appear 7 - Set the fund to your library 8 - Now it appears in suggestions management -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18743 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 [Bug 18743] Filter suggestion lists correctly for IndependentBranches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96292&action=edit Bug 24242: Display funds that the logged in user can access - suggestions The design of this script is pretty bad and any modifications is a challenge. Here we are trying to display to display the funds available for the logged in user. I did not understand previous code, as we are doing a limit using CanUserUseBudget, I do not think it makes sense to retrieve funds for a given library. Also, I am wondering if the dropdown list in the filters has ever been populated: budgetid_loop in the template *never* appeared in the history of suggestion.pl (??) Test plan: Search for suggestions Add/edit suggestions => The funds in the dropdown list should be the ones the logged in user can use. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96292|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96490&action=edit Bug 24242: Display funds that the logged in user can access - suggestions The design of this script is pretty bad and any modifications is a challenge. Here we are trying to display to display the funds available for the logged in user. I did not understand previous code, as we are doing a limit using CanUserUseBudget, I do not think it makes sense to retrieve funds for a given library. Also, I am wondering if the dropdown list in the filters has ever been populated: budgetid_loop in the template *never* appeared in the history of suggestion.pl (??) Test plan: Search for suggestions Add/edit suggestions => The funds in the dropdown list should be the ones the logged in user can use. Signed-off-by: hc <hc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Holly <hc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc@interleaf.ie Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96490|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96577&action=edit Bug 24242: Display funds that the logged in user can access - suggestions The design of this script is pretty bad and any modifications is a challenge. Here we are trying to display to display the funds available for the logged in user. I did not understand previous code, as we are doing a limit using CanUserUseBudget, I do not think it makes sense to retrieve funds for a given library. Also, I am wondering if the dropdown list in the filters has ever been populated: budgetid_loop in the template *never* appeared in the history of suggestion.pl (??) Test plan: Search for suggestions Add/edit suggestions => The funds in the dropdown list should be the ones the logged in user can use. Signed-off-by: hc <hc@interleaf.ie> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder a bit about the use case here: I could imagine someone checking the suggestions and picking the funds and someone else ordering it later. But this clearly fixes a regression, philosophical discussions can happen later :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org