https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41960 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 194251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194251&action=edit Bug 41960: Add new systempreference 'OverduesBlockHolds' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41960 --- Comment #3 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 194253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194253&action=edit Bug 41960: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41960 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194252|0 |1 is obsolete| | --- Comment #4 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 194334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194334&action=edit Bug 41960: Add option to block placing hold when patron has overdues Some libraries may want to block the possibility of placing hold when a patron has overdues. Currently, a patron is blocked when they has mode than maxoutstanding fines or when the account has been debarred (e.g. as a result of having overdues). But there is no possibility to directly block reserves in case of an overdue. Test plan: ========== 1. Check out any book to any user. 2. In ktd --dbshell, change date_due to an earlier date. 3. In a private window, log in as that user (change their password first) and place an order for another book. You will be able to do this despite the overdue items. 4. Apply the patch, updatedatabase, restart_all. 5. Set OverduesBlockHolds to 'Block'. 6. Repeat step 3. You should get the message "Sorry, you cannot place holds. You are not permitted to place holds while you have overdue items on your account." 7. Change OverduesBlockHolds to 'Don't block'. 8. Repeat step 3. You should be able to place an order. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41960 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194251|0 |1 is obsolete| | Attachment #194253|0 |1 is obsolete| | Attachment #194334|0 |1 is obsolete| | --- Comment #5 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 194363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194363&action=edit Bug 41960: Add new systempreference 'OverduesBlockHolds' Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41960 --- Comment #7 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 194365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194365&action=edit Bug 41960: Add option to block placing hold when patron has overdues Some libraries may want to block the possibility of placing hold when a patron has overdues. Currently, a patron is blocked when they has mode than maxoutstanding fines or when the account has been debarred (e.g. as a result of having overdues). But there is no possibility to directly block reserves in case of an overdue. Test plan: ========== 1. Check out any book to any user. 2. In ktd --dbshell, change date_due to an earlier date. 3. In a private window, log in as that user (change their password first) and place an order for another book. You will be able to do this despite the overdue items. 4. Apply the patch, updatedatabase, restart_all. 5. Set OverduesBlockHolds to 'Block'. 6. Repeat step 3. You should get the message "Sorry, you cannot place holds. You are not permitted to place holds while you have overdue items on your account." 7. Change OverduesBlockHolds to 'Don't block'. 8. Repeat step 3. You should be able to place an order. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41960 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194364|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41960 --- Comment #8 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 196058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196058&action=edit Bug 41960: Add new systempreference 'OverduesBlockHolds' Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41960 --- Comment #10 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 196060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196060&action=edit Bug 41960: Unit tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41960 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196058|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41960 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196060|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41960 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 196166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196166&action=edit Bug 41960: Add option to block placing hold when patron has overdues Some libraries may want to block the possibility of placing hold when a patron has overdues. Currently, a patron is blocked when they has mode than maxoutstanding fines or when the account has been debarred (e.g. as a result of having overdues). But there is no possibility to directly block reserves in case of an overdue. Test plan: ========== 1. Check out any book to any user. 2. In ktd --dbshell, change date_due to an earlier date. 3. In a private window, log in as that user (change their password first) and place an order for another book. You will be able to do this despite the overdue items. 4. Apply the patch, updatedatabase, restart_all. 5. Set OverduesBlockHolds to 'Block'. 6. Repeat step 3. You should get the message "Sorry, you cannot place holds. You are not permitted to place holds while you have overdue items on your account." 7. Change OverduesBlockHolds to 'Don't block'. 8. Repeat step 3. You should be able to place an order. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41960 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | CC| |victor@tuxayo.net --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Here is another signoff. I'll try to come back quickly to review the code testing note: when checking out, you can directly specify a due date in the past -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41960 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- can_place_holds() is not called by - the staff interface - SIP - ILS-DI but it's called by the REST API and the OPAC. Is there anything else to check? Given all that, it needs to be reflected in - the syspref name - it's description in the syspref UI - the bug name (used in release notes) - anything else? It introduces inconsistencies (depending on how the patron tries to place a hold) but it might be ok if the scope is well documented. As on the long run, we should eventually converge on having can_place_holds() being used by everything. But I don't know how to simply name things here. Maybe leave the syspref name (to avoid having to rename it) and the description and bug name will do? -- You are receiving this mail because: You are watching all bug changes.