[Bug 20607] New: Elasticsearch - ability to add a relevancy weight in mappings.yaml file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Bug ID: 20607 Summary: Elasticsearch - ability to add a relevancy weight in mappings.yaml file Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: claire.hernandez@biblibre.com The code could be able to inject mappings and weight if a mapping in mappings.yaml file contains boost-in-simple-search: Exemple: Personal-name: label: Personal-name mappings: - facet: '' marc_field: 100abcdefghjklmnopqrstvxyz marc_type: marc21 sort: ~ suggestible: '' - facet: '' marc_field: 100abcdefghjklmnopqrstvxyz marc_type: normarc sort: ~ suggestible: '' type: '' boost-in-simple-search: 4 4 is added in field weight in table search_field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 --- Comment #1 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> --- (Maybe an enhancement could be : ``` mappings: - ... settings: boost-in-simple-search: 4 ``` in replacement of ``` mappings: - ... boost-in-simple-search: 4 ``` but not sure) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 [Bug 18316] Add weighting/relevancy options to ElasticSearch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | CC| |alex.arnaud@biblibre.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand@bulac.fr, | |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 --- Comment #2 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 74805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74805&action=edit Bug 20607 - Make Koha::SearchEngine::Elasticsearch::reset_elasticsearch_mappings take weight into account Test plan: - apply BZ 18316 and this one, - update DB and schema files, - edit admin/searchengine/elasticsearch/mappings.yaml to add weight for some fields, - go to admin > search engine configuration, - reset your mappings (add ?op=reset&i_know_what_i_am_doing=1 to url), - check that weights you've added are set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Bug 20607 depends on bug 18316, which changed state. Bug 18316 Summary: Add weighting/relevancy options to ElasticSearch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Björn Nylén <bjorn.nylen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen@ub.lu.se --- Comment #3 from Björn Nylén <bjorn.nylen@ub.lu.se> --- The functionality works but the tests fail due to the weight is beeing returned as a decimal number. # Failed test 'Match search field is weighted with 15' # at t/db_dependent/Koha/SearchEngine/Elasticsearch/Reset.t line 61. # got: '15.00' # expected: '15' # Failed test 'Title search field is weighted with 20' # at t/db_dependent/Koha/SearchEngine/Elasticsearch/Reset.t line 64. # got: '20.00' # expected: '20' # Looks like you failed 2 tests of 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #4 from Michal Denar <black23@gmail.com> --- Alex, can you rebase this bug on master? Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74805|0 |1 is obsolete| | --- Comment #5 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 87402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87402&action=edit Bug 20607 - Make Koha::SearchEngine::Elasticsearch::reset_elasticsearch_mappings take weight into account Test plan: - apply this patch, - edit admin/searchengine/elasticsearch/mappings.yaml to add weight for some fields, - go to admin > search engine configuration, - reset your mappings (add ?op=reset&i_know_what_i_am_doing=1 to url), - check that weights you've added are set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Michal Denar from comment #4)
Alex, can you rebase this bug on master?
Thank you.
Done! Thank you for reminding me of that BZ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 e.betemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 e.betemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|e.betemps@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87402|0 |1 is obsolete| | --- Comment #7 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 87874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87874&action=edit Bug 20607 - Make Koha::SearchEngine::Elasticsearch::reset_elasticsearch_mappings take weight into account Test plan: - apply this patch, - edit admin/searchengine/elasticsearch/mappings.yaml to add weight for some fields, - go to admin > search engine configuration, - reset your mappings (add ?op=reset&i_know_what_i_am_doing=1 to url), - check that weights you've added are set Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Patches work, however, the tests delete all my data, then start a transaction at the end? QA tool doesn't like commit title -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91560&action=edit Bug 20607: Make Koha::SearchEngine::Elasticsearch::reset_elasticsearch_mappings take weight into account Test plan: - apply this patch, - edit admin/searchengine/elasticsearch/mappings.yaml to add weight for some fields, - go to admin > search engine configuration, - reset your mappings (add ?op=reset&i_know_what_i_am_doing=1 to url), - check that weights you've added are set Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91561&action=edit Bug 20607: (QA follow-up) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #87874|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org