[Bug 36911] New: Reindent circ-menu.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36911 Bug ID: 36911 Summary: Reindent circ-menu.inc Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I would like to reformat circ-menu.inc so that it has consistent spacing and indentation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36911 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36911 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166985&action=edit Bug 36911: Reindent circ-menu.inc This patch reindents the circ-menu include file so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and enable the 'CircSidebar' system preference if necessary. - View any circulation page, including the checkout page, to confirm that the left-hand sidebar menu is unchanged. - Test with the 'patronimages' system preference both on and off. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36911 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166986&action=edit Bug 36911: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36911 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36911 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166985|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 167199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167199&action=edit Bug 36911: Reindent circ-menu.inc This patch reindents the circ-menu include file so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and enable the 'CircSidebar' system preference if necessary. - View any circulation page, including the checkout page, to confirm that the left-hand sidebar menu is unchanged. - Test with the 'patronimages' system preference both on and off. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36911 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166986|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 167200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167200&action=edit Bug 36911: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picking an easy one out of QA queue :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36911 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36911 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.02 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36911 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not to impact oldstable 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36911 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the release notes| |circ-menu.inc include file | |used for the left-hand | |sidebar menu on circulation | |pages (when the CircSidebar | |system preference). It | |reindents the file so that | |it has consistent | |indentation, and adds | |comments to highlight the | |markup structure. These | |changes have no visible | |effect on the pages. CC| |david@davidnind.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #9 from David Nind <david@davidnind.com> --- No changes to the manual are required - there are no changes to the UI or functionality. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org