https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16321 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50532&action=edit Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade This patch fixes a problem with the 'Show all details' checkbox on the acquisitions basket page which prevented the checkbox from triggering the correct show/hide action on the table of orders. To test, apply the patch and go to Acquisitions. - Locate a vendor which has an open basket with multiple orders. - View the details of that basket. - Click the 'Show all details' checkbox above the table of orders. - Checking the box should trigger the display of additional columns in the table. - Unchecking the box should hide them again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16321 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50532|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16321 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50534&action=edit Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade This patch fixes problems with show/hide actions on a few pages caused by some problematic jQuery syntax. To test, apply the patch and go to Acquisitions. Testing basket.tt: - Locate a vendor which has an open basket with multiple orders. - View the details of that basket. - Click the 'Show all details' checkbox above the table of orders. - Checking the box should trigger the display of additional columns in the table. - Unchecking the box should hide them again. Testing invoice.tt: - Go to Acquisitions -> Invoices and perform an invoice search. - Click to view an invoice which includes one or more received records. - Click the 'Show all details' checkbox above the table of titles and confirm that it fuctions as described above. Testing newordersubscription.tt: - Go to Acquisitions and locate a vendor which is linked to a subscription - Create or add to a basket for that vendor. - Add an order using the 'From a subscription' option. - Perform a search for subscriptions. - In the table of subscriptions search results, checking or unchecking the "Show only renewed" checkbox should work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16321 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50534|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 50710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50710&action=edit Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade This patch fixes problems with show/hide actions on a few pages caused by some problematic jQuery syntax. To test, apply the patch and go to Acquisitions. Testing basket.tt: - Locate a vendor which has an open basket with multiple orders. - View the details of that basket. - Click the 'Show all details' checkbox above the table of orders. - Checking the box should trigger the display of additional columns in the table. - Unchecking the box should hide them again. Testing invoice.tt: - Go to Acquisitions -> Invoices and perform an invoice search. - Click to view an invoice which includes one or more received records. - Click the 'Show all details' checkbox above the table of titles and confirm that it fuctions as described above. Testing newordersubscription.tt: - Go to Acquisitions and locate a vendor which is linked to a subscription - Create or add to a basket for that vendor. - Add an order using the 'From a subscription' option. - Perform a search for subscriptions. - In the table of subscriptions search results, checking or unchecking the "Show only renewed" checkbox should work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16321 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50710|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50730&action=edit Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade This patch fixes problems with show/hide actions on a few pages caused by some problematic jQuery syntax. To test, apply the patch and go to Acquisitions. Testing basket.tt: - Locate a vendor which has an open basket with multiple orders. - View the details of that basket. - Click the 'Show all details' checkbox above the table of orders. - Checking the box should trigger the display of additional columns in the table. - Unchecking the box should hide them again. Testing invoice.tt: - Go to Acquisitions -> Invoices and perform an invoice search. - Click to view an invoice which includes one or more received records. - Click the 'Show all details' checkbox above the table of titles and confirm that it fuctions as described above. Testing newordersubscription.tt: - Go to Acquisitions and locate a vendor which is linked to a subscription - Create or add to a basket for that vendor. - Add an order using the 'From a subscription' option. - Perform a search for subscriptions. - In the table of subscriptions search results, checking or unchecking the "Show only renewed" checkbox should work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16321 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- It's not strictly needed in 3.22.x, but it works with jQuery 1.7.2 too, and improves code readability. Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.