[Bug 39153] New: About does not handle log4perl warnings correctly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39153 Bug ID: 39153 Summary: About does not handle log4perl warnings correctly. Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org There is a check in tab about which should be moved to sysinfo.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39153 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39153 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39154 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39154 [Bug 39154] About: add a warning for obsoleted sip.log -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39153 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39155 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39153 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39153 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178268&action=edit Bug 39153: Move log4perl checks in about.pl They were mostly under tab about, but they should be under sysinfo. Test plan: Move your log4perl file and verify that about complains on sysinfo. Note that you cannot simulate logfile_not_writable, since it crashes plack.psgi before reaching about.pl. See 39155. Bonus: Edit the moved if( !-w $file ) test and replace it by if ( 1 ). Restart and verify that you now have an error message on sysinfo. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39153 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178268|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178269&action=edit Bug 39153: Move log4perl checks in about.pl They were mostly under tab about, but they should be under sysinfo. Test plan: If you would move your log4perl file, plack.psgi crashes. So sorry but we cannot test that. Note that you cannot simulate logfile_not_writable either, since it also crashes plack.psgi before reaching about.pl. See 39155. So a trivial hack remains: Bonus: Edit about.pl and changed the moved if( !-w $file ) test and replace it by if ( 1 ) in the new sub log4perl_check. Restart and verify that you now have an error message on sysinfo. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39153 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39153 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178269|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 178299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178299&action=edit Bug 39153: Move log4perl checks in about.pl They were mostly under tab about, but they should be under sysinfo. Test plan: If you would move your log4perl file, plack.psgi crashes. So sorry but we cannot test that. Note that you cannot simulate logfile_not_writable either, since it also crashes plack.psgi before reaching about.pl. See 39155. So a trivial hack remains: Bonus: Edit about.pl and changed the moved if( !-w $file ) test and replace it by if ( 1 ) in the new sub log4perl_check. Restart and verify that you now have an error message on sysinfo. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39153 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178299|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179071&action=edit Bug 39153: Move log4perl checks in about.pl They were mostly under tab about, but they should be under sysinfo. Test plan: If you would move your log4perl file, plack.psgi crashes. So sorry but we cannot test that. Note that you cannot simulate logfile_not_writable either, since it also crashes plack.psgi before reaching about.pl. See 39155. So a trivial hack remains: Bonus: Edit about.pl and changed the moved if( !-w $file ) test and replace it by if ( 1 ) in the new sub log4perl_check. Restart and verify that you now have an error message on sysinfo. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39153 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39153 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39153 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not backport to 24.11.x for UI stability -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org