[Bug 36276] New: Cannot edit Identity Provider after creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 Bug ID: 36276 Summary: Cannot edit Identity Provider after creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: olivier.hubert@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Once an identity provider is created, it is no longer possible to easily edit it, as the form for editing the identity provider contains no value. Moreover, the provider's name is replace with " (quotation mark). Steps to reproduce: 1. Launch KTD or Koha instance using up-to-date master branch. 2. In the Administration menu, go to the Identity Providers page. 3. Click on the button to create a new identity provider. 4. Fill in the required fields, using test data. 5. Save the identity provider. 6. Click the "Edit" button for the newly created identity provider. 7. Notice that the form's fields are empty and the provider's name has been changed to ". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 Olivier Hubert <olivier.hubert@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olivier.hubert@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #1 from David Nind <david@davidnind.com> --- I can confirm this behaviour. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 koha@zefanjas.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@zefanjas.de --- Comment #2 from koha@zefanjas.de --- I can confirm this, too. Happens also, if you want to edit an Identity Provider Domain. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168682&action=edit Bug 36276: Fix editing of identity provider and domains This patch fixes identity_providers.pl to remove the "cud-" prefix for two operations which are not POSTed: editing identity providers and editing domains. To test, apply the patch and restart services. - Go to Administration -> Identity providers. - If necessary, create an identity provider and then click "Manage domains" -> New identity provider domain to create a new domain. - From the list of domains, click "Edit" - The edit form should appear with all the correct details prefilled. - Check that the page title, breadcrumbs, and page header all show the correct domain. - Make a change to the domain and confirm that the changes are saved. - From the list of identity providers, click "Edit" - This form should also load correctly. - Submitted changes should be saved correctly. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168682|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 168683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168683&action=edit Bug 36276: Fix editing of identity provider and domains This patch fixes identity_providers.pl to remove the "cud-" prefix for two operations which are not POSTed: editing identity providers and editing domains. To test, apply the patch and restart services. - Go to Administration -> Identity providers. - If necessary, create an identity provider and then click "Manage domains" -> New identity provider domain to create a new domain. - From the list of domains, click "Edit" - The edit form should appear with all the correct details prefilled. - Check that the page title, breadcrumbs, and page header all show the correct domain. - Make a change to the domain and confirm that the changes are saved. - From the list of identity providers, click "Edit" - This form should also load correctly. - Submitted changes should be saved correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the identity release notes| |provider and domain forms | |so that the information is | |now editable | |(Administration > | |Additional parameters > | |Identity providers). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168683|0 |1 is obsolete| | --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Created attachment 168686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168686&action=edit Bug 36276: Fix editing of identity provider and domains This patch fixes identity_providers.pl to remove the "cud-" prefix for two operations which are not POSTed: editing identity providers and editing domains. To test, apply the patch and restart services. - Go to Administration -> Identity providers. - If necessary, create an identity provider and then click "Manage domains" -> New identity provider domain to create a new domain. - From the list of domains, click "Edit" - The edit form should appear with all the correct details prefilled. - Check that the page title, breadcrumbs, and page header all show the correct domain. - Make a change to the domain and confirm that the changes are saved. - From the list of identity providers, click "Edit" - This form should also load correctly. - Submitted changes should be saved correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Thanks, Owen. Legend! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot edit Identity |Cannot edit identity |Provider after creation |provider after creation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For my understanding... I thought that any operation that requires a data change should use POST and cud- - Why are we moving the other direction here with these patches? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #9 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7)
For my understanding... I thought that any operation that requires a data change should use POST and cud- - Why are we moving the other direction here with these patches?
The edit_form op is loading the form, it's read only to populate the page. When edits are saved the op is 'cud-edit_save' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens (kidclamp) from comment #9)
(In reply to Katrin Fischer from comment #7)
For my understanding... I thought that any operation that requires a data change should use POST and cud- - Why are we moving the other direction here with these patches?
The edit_form op is loading the form, it's read only to populate the page. When edits are saved the op is 'cud-edit_save'
Thanks for explaining! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.04 released in| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- CUD not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36276 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #13 from David Nind <david@davidnind.com> --- This fixes a bug - no change to the interface, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org