[Bug 22774] New: Limit Purchase Suggestion in a specified Time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Bug ID: 22774 Summary: Limit Purchase Suggestion in a specified Time period Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: joy@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Many libraries would like the ability to limit purchase suggestions made by a patron to a certain number over a specified period. i.e. 3 suggestions every 30 days. The MaxOpenSuggestions works to limit 'open' suggestions, but does not take into account the total suggestions made by patrons. We need the ability to limit the number of suggestions a patron can make in a "rolling number of weeks" (over last X weeks). The variables for this would be the number of suggestions and the number of rolling weeks. Suggested system preference "MaxTotalSuggestions" with two variables. First is the number of total suggestions and the second is the number of days. e.g. MaxTotalSuggestion Allow 3 total suggestions over 30 days. (user configures the numbers to suit their policy) Result: Users are prevented from making any suggestions if the total suggestions (pending/checked/accepted/rejected) they've made over the last X days is equal to the max specified. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kohadevinim@devinim.com.tr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com --- Comment #1 from Lisette Scheer <lisetteslatah@gmail.com> --- This would be very helpful for a number of libraries I've talked with about purchase suggestions. Lisette -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #2 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 95940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95940&action=edit Bug 22774: New systempreferences for suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #3 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 95941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95941&action=edit Bug 22774: Limit Purchase Suggestion in a specified Time period Test plan: 1- Apply this patch 2- Run updatedatabase.pl 3- By default you may have max. 3 suggestions in last 30 days. 4- Go to purchase suggestion page from OPAC 5- If you exceed limits of suggestions in step 3 you will not able to add new suggestions. 6- If you want to change the limits go to systempreferences and change MaxTotalSuggestions and NumberOfSuggestionDays parameters. 7- Test again from step 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #4 from Kelly McElligott <kelly@bywatersolutions.com> --- Hi, Upon testing this, I received this error when trying to place a hold on the OPAC side. Could not compile /kohadevbox/koha/opac/opac-suggestions.pl: Global symbol "$suggestions_loop" requires explicit package name (did you forget to declare "my $suggestions_loop"?) at /kohadevbox/koha/opac/opac-suggestions.pl line 144 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95941|0 |1 is obsolete| | --- Comment #5 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 97061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97061&action=edit Bug 22774: (follow-up) Limit Purchase Suggestion in a specified Time period This was resolved. Fail occured because of some changes after we commit the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95940|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97070&action=edit Bug 22774: New systempreferences for suggestions Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97061|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 97071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97071&action=edit Bug 22774: (follow-up) Limit Purchase Suggestion in a specified Time period Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |tomascohen@gmail.com --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not think it is correct to have the condition check in the controller. I am pretty sure Tomas will disagree with that as we will want the API taking into account those new sysprefs. CCing Tomas to get his opinion on this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 rkuiper@roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper@roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97070|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 99045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99045&action=edit Bug 22774: New systempreferences for suggestions Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97071|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 99046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99046&action=edit Bug 22774: (follow-up) Limit Purchase Suggestion in a specified Time period Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Limit Purchase Suggestion |Limit purchase suggestion |in a specified Time period |in a specified time period -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) The database update will limit the number of suggestions for existing installations: + $dbh->do( q{ + INSERT IGNORE INTO systempreferences (variable,value,explanation,type) VALUES + ('MaxTotalSuggestions','3','Number of total suggestions','free'), + ('NumberOfSuggestionDays','30','days','free') + }); This is against the "rules" as we always aim for having no change of behaviour on update. We should set them to empty (unlimited) 2) For the same reason I am wondering about the default settings in the YAML file, I don't think they are needed. 3) This patch set misses the change to sysprefs.sql for setting up new installations. While we could do the 3 and 30 there, I wonder if we should be a little less restrictive there as well? 4) Please (re)add descriptions of the changes and test plans to the commit messages. I've seen quite a lot of them showing here but not being part of the attached files. Make sure you write them up in your git commit step, not when using git bz attach, as the latter won't change the files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #12 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 99380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99380&action=edit New systempreferences for suggestions added to sysprefs.sql New patch added for new installations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99380|0 |1 is obsolete| | --- Comment #13 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 99381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99381&action=edit Bug 22774: New systempreferences for suggestions added to sysprefs.sql New patch added for new installations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99045|0 |1 is obsolete| | --- Comment #14 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 99382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99382&action=edit Bug 22774: (follow-up) New systempreferences for suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99382|0 |1 is obsolete| | --- Comment #15 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 100192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100192&action=edit Bug 22774: New systempreferences for suggestions Test plan: 1- Apply this patch 2- Run updatedatabase.pl 3- By default you may have max. 3 suggestions in last 30 days. 4- Go to purchase suggestion page from OPAC 5- If you exceed limits of suggestions in step 3 you will not able to add new suggestions. 6- If you want to change the limits go to systempreferences and change MaxTotalSuggestions and NumberOfSuggestionDays parameters. 7- Test again from step 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100192|0 |1 is obsolete| | --- Comment #16 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 100193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100193&action=edit Bug 22774: New systempreferences for suggestions Test plan: 1- Apply this patch 2- Run updatedatabase.pl 3- By default you may have max. 3 suggestions in last 30 days. 4- Go to purchase suggestion page from OPAC 5- If you exceed limits of suggestions in step 3 you will not able to add new suggestions. 6- If you want to change the limits go to systempreferences and change MaxTotalSuggestions and NumberOfSuggestionDays parameters. 7- Test again from step 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99046|0 |1 is obsolete| | Attachment #99381|0 |1 is obsolete| | Attachment #100193|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100912&action=edit Bug 22774: New systempreferences for suggestions added to sysprefs.sql Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100913&action=edit Bug 22774: Limit Purchase Suggestion in a specified Time period Test plan: 1 - Apply this patch 2 - Run updatedatabase.pl 3 - By default the preferences are blank and do not limit. 4 - Set the limits to 3 in 30 days 5 - Go to purchase suggestion page from OPAC as a logged in patron 6 - Place 3 suggestions and confirm you cannot place any more 7 - Alter one of the suggestions to have been made more than 30 days ago UPDATE suggestions SET suggesteddate = '2020-01-01' WHERE suggestionid=3; 8 - Confirm you can place another suggestion 9 - Log out of OPAC 10 - Make sure AnonSyggestions is set to 'Allow' and AnonymousPatron is set 11 - Confirm anonymous suggestions are not limited by the syspref 12 - Confirm that a blank value in either MaxTotalSuggestions or NumberOfSuggestionDays does not limit suggestions Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #19 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 101448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101448&action=edit Bug 22774: (follow-up) Limit Purchase Suggestion in a specified Time period We changed the code to satisfy new methods: we used Koha::Suggestions->search()->count instead of scalar search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Limit purchase suggestion |Limit number of purchase |in a specified time period |suggestions per patron in a | |specified time period --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) QA test tools Looks good, only got what looks like a false positive: Processing additional checks * Email's author 'kohadevinim@devinim.com.tr' seems invalid 2) Capitalization (Bug 22774 - Limit Purchase Suggestion in a specified Time period) Please stick with our capitalization rules everywhere! :) Still testing here, but won't finish tonight. Will fix 2) myself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #21 from Devinim <kohadevinim@devinim.com.tr> --- (In reply to Katrin Fischer from comment #20)
1) QA test tools
Looks good, only got what looks like a false positive:
Processing additional checks * Email's author 'kohadevinim@devinim.com.tr' seems invalid
Hi Katrin, I didn't understand that. It is one of our valid email address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
I didn't understand that. It is one of our valid email address.
Yep, was just noting it - we can safely ignore it in my opinion. Maybe it's not aware of com.tr? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- You can ignore it, IIRC I added a check on "*koha*", to catch example developer emails (like the default from kohadevbox, etc.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Oh, sorry, it looks like I forgot to continue here - will do it now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100912|0 |1 is obsolete| | Attachment #100913|0 |1 is obsolete| | Attachment #101448|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102882&action=edit Bug 22774: New systempreferences for suggestions added to sysprefs.sql Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102883&action=edit Bug 22774: Limit Purchase Suggestion in a specified Time period Test plan: 1 - Apply this patch 2 - Run updatedatabase.pl 3 - By default the preferences are blank and do not limit. 4 - Set the limits to 3 in 30 days 5 - Go to purchase suggestion page from OPAC as a logged in patron 6 - Place 3 suggestions and confirm you cannot place any more 7 - Alter one of the suggestions to have been made more than 30 days ago UPDATE suggestions SET suggesteddate = '2020-01-01' WHERE suggestionid=3; 8 - Confirm you can place another suggestion 9 - Log out of OPAC 10 - Make sure AnonSyggestions is set to 'Allow' and AnonymousPatron is set 11 - Confirm anonymous suggestions are not limited by the syspref 12 - Confirm that a blank value in either MaxTotalSuggestions or NumberOfSuggestionDays does not limit suggestions Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102884&action=edit Bug 22774: (follow-up) Limit purchase suggestion in a specified time period Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102885&action=edit Bug 22774: (QA follow-up) Add syspref descriptions to database update and sysprefs.sql Moves the updatedatabase entry to the new format and adds information for the explanation column of the systempreferences table. Also slightly rephrases the description in the system preference editor. To test: - Verify database update still works the same with addition of explanations - Verify the sys pref description makes sense -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102886&action=edit Bug 22774: (QA follow-up) Rephrase OPAC notes I've changed the OPAC notes a little bit, main change is the removal of the <b> tags used to highlight single words in one sentence as they would result in splitting up the sentence into multiple parts which makes proper translations really hard. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- RM, as a native speaker, please check the follow-ups make sense :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #31 from Devinim <kohadevinim@devinim.com.tr> --- Thanks Katrin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #8)
I do not think it is correct to have the condition check in the controller. I am pretty sure Tomas will disagree with that as we will want the API taking into account those new sysprefs.
CCing Tomas to get his opinion on this.
Discussed with Tomas and we agreed to push this and followup with an API fix later.. a bigger discussion on how to handle things like needs to happen in a broader scope. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #30)
RM, as a native speaker, please check the follow-ups make sense :)
Looks good to me :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Got this while upgrading: kohadev-koha@156b126f55d3:/kohadevbox/koha$ perl installer/data/mysql/updatedatabase.pl Upgrade to 19.12.00.068 done [19:57:44]: Bug 21190 - Add prefs AuthFailureLog and AuthSuccessLog Upgrade to 19.12.00.069 done [19:57:44]: Bug 22784 - Add a new suggestions.archived column Upgrade to 19.12.00.070 done [19:57:44]: Bug 22774 - Limit purchase suggestion in a specified time period DBD::mysql::db selectall_arrayref failed: Non-grouping field 'c' is used in HAVING clause [for Statement " SELECT category, authorised_value, COUNT(concat(category, ':', authorised_value)) AS c FROM authorised_values GROUP BY category, authorised_value HAVING c > 1 "] at installer/data/mysql/updatedatabase.pl line 21576. Can't use an undefined value as an ARRAY reference at installer/data/mysql/updatedatabase.pl line 21582. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Wrong bug, sorry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #37 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Limit number of purchase |Add ability to limit the |suggestions per patron in a |number of purchase |specified time period |suggestions a patron may | |submit in a specified time | |period -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows the release notes| |library to limit the number | |of purchase suggestions a | |user may submit within a | |given time period. | | | |**New | |system preferences**: | |`MaxTotalSuggestions` | |defaults to empty | |(unrestricted) and | |`NumberOfSuggestionDays` | |defaults to empty | |(disabled). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Daniel Gaghan <daniel.gaghan@pueblolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan@pueblolibrary | |.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 --- Comment #38 from Daniel Gaghan <daniel.gaghan@pueblolibrary.org> --- Thanks folks for all your work, we just discovered this enhancement and our collection development librarians are looking forward to this feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org