[Bug 14119] New: Missing de-DE DISCHARGE message
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Bug ID: 14119 Summary: Missing de-DE DISCHARGE message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 8007 DB changes forgot de-DE DISCHARGE message, prove xt/sample_notices.t fails -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 38760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38760&action=edit Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | Patch complexity|--- |Trivial patch --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- If a German patch is provided, please reset assignee :) I will sign. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- This works, but I rather a German counter patch. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38760|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38761&action=edit Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> As noted, a German counter patch is preferred. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 38765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38765&action=edit Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38765|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 38766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38766&action=edit [SIGNED_OFF] Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Right wording :) Fixed version -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bgkriegel@gmail.com |veron@veron.ch Status|Needs Signoff |Signed Off --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- First patch obsoleted -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38761|1 |0 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 38761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38761 Bug 14119: Missing de-DE DISCHARGE message It looks like the second patch requires the first. Unchecking 'obsolete' for a clean apply. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38761|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38770&action=edit Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> As noted, a German counter patch is preferred. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Required for a clean install of German patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38766|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38771&action=edit Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Right wording :) Fixed version Signed-off-by: Mark Tompsett <mtompset@hotmail.com> German version. YAY! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38770|0 |1 is obsolete| | Attachment #38771|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38784&action=edit [PASSED QA] Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> As noted, a German counter patch is preferred. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38785&action=edit [PASSED QA] Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Right wording :) Fixed version Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14119 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Good job Bernardo and Marc! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org