[Bug 17327] New: Item level holds no longer enforced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Bug ID: 17327 Summary: Item level holds no longer enforced Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Reported by Katrin: Example: - on shelf holds allowed - holds allowed 5 - holds on same record allowed 5 - FORCE item level holds On a record with only one item, you can only place a record level hold in OPAC now - which is against your circulation conditions. Another example: - record with 2 items - circulation rules as above, 1 hold allowed on the record - Item level holds: forced I can only place record level holds in OPAC and staff. At the moment, I am not able to place item level holds in any circumstances in my installation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55744&action=edit Bug 17327 - Add unit test for regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55745&action=edit Bug 17327 - Item level holds no longer enforced Reported by Katrin: Example: - on shelf holds allowed - holds allowed 5 - holds on same record allowed 5 - FORCE item level holds On a record with only one item, you can only place a record level hold in OPAC now - which is against your circulation conditions. Another example: - record with 2 items - circulation rules as above, 1 hold allowed on the record - Item level holds: forced I can only place record level holds in OPAC and staff. At the moment, I am not able to place item level holds in any circumstances in my installation. Test Plan: 1) Apply the unit test patch 2) prove t/db_dependent/Reserves/MultiplePerRecord.t should fail 3) Apply the second patch 4) prove t/db_dependent/Reserves/MultiplePerRecord.t should pass 5) Attempt to replicate one of the examples above, you should be unable to -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55744|0 |1 is obsolete| | --- Comment #3 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 55761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55761&action=edit Bug 17327 - Add unit test for regression Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55745|0 |1 is obsolete| | --- Comment #4 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 55762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55762&action=edit Bug 17327 - Item level holds no longer enforced Reported by Katrin: Example: - on shelf holds allowed - holds allowed 5 - holds on same record allowed 5 - FORCE item level holds On a record with only one item, you can only place a record level hold in OPAC now - which is against your circulation conditions. Another example: - record with 2 items - circulation rules as above, 1 hold allowed on the record - Item level holds: forced I can only place record level holds in OPAC and staff. At the moment, I am not able to place item level holds in any circumstances in my installation. Test Plan: 1) Apply the unit test patch 2) prove t/db_dependent/Reserves/MultiplePerRecord.t should fail 3) Apply the second patch 4) prove t/db_dependent/Reserves/MultiplePerRecord.t should pass 5) Attempt to replicate one of the examples above, you should be unable to Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth@kul.oslo.k | |ommune.no Status|Needs Signoff |Signed Off --- Comment #5 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Tests ok. patron without holds -> both item and record level allowed patron with record level hold -> only record hold allowed patron with item level hold -> only item hold allowed How item/record level holds should be enforced by circulation rules is probably the scope of another bug, as this needs to be pushed to master quickly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55761|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 55825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55825&action=edit Bug 17327: Add unit test for regression Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55762|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 55826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55826&action=edit Bug 17327: Item level holds no longer enforced Reported by Katrin: Example: - on shelf holds allowed - holds allowed 5 - holds on same record allowed 5 - FORCE item level holds On a record with only one item, you can only place a record level hold in OPAC now - which is against your circulation conditions. Another example: - record with 2 items - circulation rules as above, 1 hold allowed on the record - Item level holds: forced I can only place record level holds in OPAC and staff. At the moment, I am not able to place item level holds in any circumstances in my installation. Test Plan: 1) Apply the unit test patch 2) prove t/db_dependent/Reserves/MultiplePerRecord.t should fail 3) Apply the second patch 4) prove t/db_dependent/Reserves/MultiplePerRecord.t should pass 5) Attempt to replicate one of the examples above, you should be unable to Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 55827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55827&action=edit Bug 17327: (QA followup) Remove Carp::Always which is not used This patch removes the need for Carp::Always in .../Reserves/MultiplePerRecord.t which is not actually used. It also removes 'undef' from Koha::Holds::forced_hold_level's last return, to comply with our QA rules. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks for the followup Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17327 Brenda Turnbull <bturnbull@livewirewarrington.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bturnbull@livewirewarringto | |n.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org