[Bug 21539] New: addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Bug ID: 21539 Summary: addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org There is no reason that MarcItemFieldsToOrder should force librarians to select a ccode and notforloan value for each item. They are both optional fields. As with location, the first value should be an empty 'none' option. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 80361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80361&action=edit Bug 21539 - addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder There is no reason that MarcItemFieldsToOrder should force librarians to select a ccode and notforloan value for each item. They are both optional fields. As with location, the first value should be an empty 'none' option. Test Plan: 1) Set up MarcItemFieldsToOrder, do *not* set mappings for ccode and notforloan 2) Add an order record to a basket that uses MarcItemFieldsToOrder 3) Note you must choose a ccode and nfl value 4) Apply this patch 5) Reload the page 6) Note you no longer have to select values for ccode and notforloan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #2 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Kyle M Hall from comment #1)
Created attachment 80361 [details] [review] Bug 21539 - addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder
There is no reason that MarcItemFieldsToOrder should force librarians to select a ccode and notforloan value for each item. They are both optional fields. As with location, the first value should be an empty 'none' option.
Test Plan: 1) Set up MarcItemFieldsToOrder, do *not* set mappings for ccode and notforloan 2) Add an order record to a basket that uses MarcItemFieldsToOrder 3) Note you must choose a ccode and nfl value 4) Apply this patch 5) Reload the page 6) Note you no longer have to select values for ccode and notforloan
Hi Kyle, I have tried to replicate this on master but have so far been unable to. What do you mean when you say 'Add an order record to a basket that uses MarcItemFieldsToOrder'? I have set up the syspref before staging the records, is there something else I need to do? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens@lancasterseminar | |y.edu --- Comment #3 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- I'm also finding that the test plan isn't clear. Here's what I tried: 1. Set up MarcItemsFieldsToOrder; used the example provided in the system preferences and set mappings for holdingbranch and itype. 2. According to the manual, MarcItemsFieldsToOrder applies to item records created from a MARC record in a staged file: a. Staged a MARC record b. Opened a basket for "My Vendor" c. Added an order to the basket from staged MARC record d. Closed the basket e. Received a shipment f. Went to record and saw new item 3. At no point in the process was I prompted to enter a ccode or not for loan value. These remained blank throughout the process. Tested on master (19.12.00.002) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Setting to FQA because of the last 2 comments - Kyle, can you please check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |andrew@bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This works as intended, testing on master. Clarifying test process. 1) Have at least one field mapped in MARCItemFieldsToOrder, but do not map CCODE or location - I used "homebranch: 947$a" 2) Set AcqCreateItem to Placing an Order 3) Have a MARC record with at least one valid value in one of the fields mapped in MARCItemFieldsToOrder - I had a record with "947$aCPL" 4) Create a basket in acq, use default item creation of Placing an Order 5) Add to basket from a new file, selecting your MARC file 6) After the file has uploaded and you've clicked "Add staged file to basket," you're taken to addorderiso2709.pl 7) On addorderiso2709.pl, click to select your bib for import 8) If your values mapped via MARCItemFieldsToOrder was set successfully, your order should include an inset "Item Record 1" box with an abbreviated item record 9) Note that collection code and location have defaulted to the first authorized value and cannot be set to empty 10) Apply patch, restart 11) Repeat steps 1-8 12) Note that collection code and location are blank by default and can be set to other values 13) Add ccode and location to you MARCItemFieldsToOrder values and your MARC record 14) Add to your basket via your updated file 15) Note that CCODE and loc populate values as desired -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26134 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26134 [Bug 26134] Error when adding to basket from new/staged file when using MARCItemFieldsToOrder -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80361|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 108553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108553&action=edit Bug 21539 - addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder There is no reason that MarcItemFieldsToOrder should force librarians to select a ccode and notforloan value for each item. They are both optional fields. As with location, the first value should be an empty 'none' option. Test Plan: 1) Set up MarcItemFieldsToOrder, do *not* set mappings for ccode and notforloan 2) Add an order record to a basket that uses MarcItemFieldsToOrder 3) Note you must choose a ccode and nfl value 4) Apply this patch 5) Reload the page 6) Note you no longer have to select values for ccode and notforloan Signed-off-by: Daniel Gaghan <daniel.gaghan@pueblolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108553|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108935&action=edit Bug 21539: addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder There is no reason that MarcItemFieldsToOrder should force librarians to select a ccode and notforloan value for each item. They are both optional fields. As with location, the first value should be an empty 'none' option. Test Plan: 1) Set up MarcItemFieldsToOrder, do *not* set mappings for ccode and notforloan 2) Add an order record to a basket that uses MarcItemFieldsToOrder 3) Note you must choose a ccode and nfl value 4) Apply this patch 5) Reload the page 6) Note you no longer have to select values for ccode and notforloan Signed-off-by: Daniel Gaghan <daniel.gaghan@pueblolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.04 |20.11.00, 20.05.04, released in| |19.11.10 --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 19.05.x, can't backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26134 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26134 [Bug 26134] Error when adding to basket from new/staged file when using MARCItemFieldsToOrder -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org