https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29599 Bug ID: 29599 Summary: addorderiso2709.pl - Discount is stored as value below 1 instead of actual percentage Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: christophe.torin@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org When adding an order from a staged file, the discount amount is stored as the value below 1 instead of the actual percentage. e.g. if you enter a disount of 25%, the stored value is 0.25 instead of 25. The percentage is currently stored as is everywhere else (when you add from suggestions, or the discount amount stored in the bookseller info) The discounted price is correctly calculated at first, but if the order is modified afterwards, the wrong discount is used, and the resulting prices are false. This was seen on version 20.11, but is still relevant on the latest versions. In the code, it is because of the way the value is handled : in addorderiso2709.pl, lines 166, 279 & 340 , the discount value is divided by 100 and later it is stored like this. The value should be used as is, then when calculating the prices, divide it by 100 if necessary. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.