[Bug 21814] New: System preferences save button can be hidden by language menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Bug ID: 21814 Summary: System preferences save button can be hidden by language menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org If the language-chooser is shown and a system preference search returns a large number of results the last submit button on the page can be hidden behind the language menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82243&action=edit Bug 21814: System preferences save button can be hidden by language menu This patch modifies the staff client CSS to give pages enough of a bottom margin that the language footer will not obscure controls appearing at the bottom of the page. To test, apply the patch and regenerate the staff client CSS. You must have one or more translations installed and enabled. StaffLangSelectorMode should be set to display the language menu in the footer. Go to Administration and search for 'opac.' Scroll to the bottom of the page and confirm that the last submit button is not hidden by the language menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82243|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 82362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82362&action=edit Bug 21814: System preferences save button can be hidden by language menu This patch modifies the staff client CSS to give pages enough of a bottom margin that the language footer will not obscure controls appearing at the bottom of the page. To test, apply the patch and regenerate the staff client CSS. You must have one or more translations installed and enabled. StaffLangSelectorMode should be set to display the language menu in the footer. Go to Administration and search for 'opac.' Scroll to the bottom of the page and confirm that the last submit button is not hidden by the language menu. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Owen, Patch works as expected but shouldn't the margin be equal to (or at least based on) the height of navbar ? For the navbar we have min-height: 20px but it's actually a bit more (30.4px for me) and the patch sets a margin of 3em. I'm not familiar with SCSS, but this looks like a good candidate for variables. Something like this: :root { $navbar_height: 30px; } .navbar { height: $navbar_height; } .main { margin-bottom: $navbar_height; } What do you think ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82370&action=edit Bug 21814: (follow-up) System preferences save button can be hidden by language menu This follow-up implements the same change by defining a variable to be used as the minimum height of the language footer navbar. A calculation is done on this value to set the bottom margin of the main area of the page. To test, apply the patch and rebuild the staff client CSS. Clear your browser cache if necessary. View the system preferences page again and confirm that the bug is still fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82362|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 82371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82371&action=edit Bug 21814: System preferences save button can be hidden by language menu This patch modifies the staff client CSS to give pages enough of a bottom margin that the language footer will not obscure controls appearing at the bottom of the page. To test, apply the patch and regenerate the staff client CSS. You must have one or more translations installed and enabled. StaffLangSelectorMode should be set to display the language menu in the footer. Go to Administration and search for 'opac.' Scroll to the bottom of the page and confirm that the last submit button is not hidden by the language menu. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82370|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 82372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82372&action=edit Bug 21814: (follow-up) System preferences save button can be hidden by language menu This follow-up implements the same change by defining a variable to be used as the minimum height of the language footer navbar. A calculation is done on this value to set the bottom margin of the main area of the page. To test, apply the patch and rebuild the staff client CSS. Clear your browser cache if necessary. View the system preferences page again and confirm that the bug is still fixed. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Is this an issue in 18.05.x branch Owen? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Martin Renvoize from comment #8)
Is this an issue in 18.05.x branch Owen?
It doesn't appear to be. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27099 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org