[Bug 28376] New: Replace obsolete jquery-ui-timepicker-addon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Bug ID: 28376 Summary: Replace obsolete jquery-ui-timepicker-addon Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org The latest jquery-ui-timepicker-addon version dates back to 2016, and we are using one dated 2014. We should replace it with something that's maintained. 'flatpickr' [1] could be used to replace timepickers and also datepickers. It is flexible enough for us to customize things, including date formatting and translations. [1] https://flatpickr.js.org/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28351 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 121257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121257&action=edit Bug 28367: PROOF OF CONCEPT Replace jQueryUI date/timepicker with Flatpickr This patch is a proof of concept demonstrating how jQueryUI date & time pickers could be replaced using the Flatpickr library (https://flatpickr.js.org/). The patch modifies two pages as test cases: - Circulation -> Renew (with SpecifyDueDates enabled), to demonstrate date and time selection. - Administration -> Patron categories -> New category, to demonstrate a date picker. I've made some customizations to the default Flatpickr library's CSS and incorporated it into staff-global.scss, so you must rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I really like it. The code is really simple, and handling dateformat seems sleek as well. The only thing I could mention is the modal feels too big. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Yes, go for it! Can we have a working version of the patch? I would like, as a first step, a POC witch takes care of two occurrences, a simple one and a complex one. We need to think about the edge cases: * time format (now it's 12h when the syspref is 24h) * manual editing * format validation * range validation (from/to) * "from today only" (no date from the paste) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #3)
* time format (now it's 12h when the syspref is 24h)
Well, maybe not, but it's confusing! https://snipboard.io/IzOBMF.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is also bootstrap-datepicker - https://github.com/uxsolutions/bootstrap-datepicker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #5)
There is also bootstrap-datepicker - https://github.com/uxsolutions/bootstrap-datepicker
I like the bootstrap integration. FTR: I chose Flatpickr because it looked like a more active project (maybe I'm biased and it is just that is buggier :-P) but also because it had time handling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121257|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123013&action=edit Bug 28367: PROOF OF CONCEPT Replace jQueryUI date/timepicker with Flatpickr This patch is a proof of concept demonstrating how jQueryUI date & time pickers could be replaced using the Flatpickr library (https://flatpickr.js.org/). NEW: I've modified the default configuration of Flatpickr instances so that a "Clear date" link is automatically appended. This eliminates the need to add a button to the markup and event handling for each case. NEW: Date/time formatting should be corrected in this revised patch. The patch modifies three pages as test cases: - Circulation -> Renew (with SpecifyDueDates enabled), to demonstrate date and time selection. - NEW: You can also test the datepicker shown when you renew an on-hold item. This demonstrates a configuration which requires that the selection be after today. - Administration -> Patron categories -> New category, to demonstrate a calendar-only date picker enforcing a date after today. - NEW: Reports -> Patrons. The "Date of birth" fields are linked so that the second cannot be before the first. I've made some customizations to the default Flatpickr library's CSS and incorporated it into staff-global.scss, so you must rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- The only thing I've found so far that Flatpickr lacks compared to jQueryUI is an option to show a "Today" button in the calendar widget. There is an addon which can provide this (https://github.com/jcsmorais/shortcut-buttons-flatpickr) but I'm not sure it's worth adding another dependency. FWIW you can type the word "today" in a Flatpickr date field and it will correctly interpret it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123013|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123324&action=edit Bug 28376: Replace jQueryUI date/timepicker with Flatpickr This patch is a proof of concept demonstrating how jQueryUI date & time pickers could be replaced using the Flatpickr library (https://flatpickr.js.org/). NEW: I've modified the default configuration of Flatpickr instances so that a "Clear date" link is automatically appended. This eliminates the need to add a button to the markup and event handling for each case. NEW: Date/time formatting should be corrected in this revised patch. The patch modifies three pages as test cases: - Circulation -> Renew (with SpecifyDueDates enabled), to demonstrate date and time selection. - NEW: You can also test the datepicker shown when you renew an on-hold item. This demonstrates a configuration which requires that the selection be after today. - Administration -> Patron categories -> New category, to demonstrate a calendar-only date picker enforcing a date after today. - NEW: Reports -> Patrons. The "Date of birth" fields are linked so that the second cannot be before the first. I've made some customizations to the default Flatpickr library's CSS and incorporated it into staff-global.scss, so you must rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123324|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 123352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123352&action=edit Bug 28376: Replace jQueryUI date/timepicker with Flatpickr This patch is a proof of concept demonstrating how jQueryUI date & time pickers could be replaced using the Flatpickr library (https://flatpickr.js.org/). NEW: I've modified the default configuration of Flatpickr instances so that a "Clear date" link is automatically appended. This eliminates the need to add a button to the markup and event handling for each case. NEW: Date/time formatting should be corrected in this revised patch. The patch modifies three pages as test cases: - Circulation -> Renew (with SpecifyDueDates enabled), to demonstrate date and time selection. - NEW: You can also test the datepicker shown when you renew an on-hold item. This demonstrates a configuration which requires that the selection be after today. - Administration -> Patron categories -> New category, to demonstrate a calendar-only date picker enforcing a date after today. - NEW: Reports -> Patrons. The "Date of birth" fields are linked so that the second cannot be before the first. I've made some customizations to the default Flatpickr library's CSS and incorporated it into staff-global.scss, so you must rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #11 from David Nind <david@davidnind.com> --- Everything seemed to work okay for me. Also like that the calendar icon is now back inside the input box. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123352|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 123997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123997&action=edit Bug 28376: Replace jQueryUI date/timepicker with Flatpickr This patch is a proof of concept demonstrating how jQueryUI date & time pickers could be replaced using the Flatpickr library (https://flatpickr.js.org/). NEW: I've modified the default configuration of Flatpickr instances so that a "Clear date" link is automatically appended. This eliminates the need to add a button to the markup and event handling for each case. NEW: Date/time formatting should be corrected in this revised patch. The patch modifies three pages as test cases: - Circulation -> Renew (with SpecifyDueDates enabled), to demonstrate date and time selection. - NEW: You can also test the datepicker shown when you renew an on-hold item. This demonstrates a configuration which requires that the selection be after today. - Administration -> Patron categories -> New category, to demonstrate a calendar-only date picker enforcing a date after today. - NEW: Reports -> Patrons. The "Date of birth" fields are linked so that the second cannot be before the first. I've made some customizations to the default Flatpickr library's CSS and incorporated it into staff-global.scss, so you must rebuild the staff client SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I like the aesthetics of this library and it works like a charm. It is an easy replacement to the current library. The use cases work: limiting date ranges, time pick, etc. The only thing I would change is the font size, as it feels a bit bigger than the rest of the Koha fonts. We might even revisit the font itself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What's the next step? This should not be part of 21.11 alone, we must replace all other occurrences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- We should be able to set a date without using the widget (ie. keep date validation and remove readonly on the input). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #15)
We should be able to set a date without using the widget (ie. keep date validation and remove readonly on the input).
From IRC oleonard> Joubu: flatpickr's "allowInput" option is true by default.
Tried again and it's working as expected now (??) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed, | |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch begins the release notes| |process of replacing an | |obsolete jQuery plugin with | |a new library for selecting | |dates and times. Koha uses | |the jQueryUI "datepicker" | |widget for selecting dates, | |and uses an additional | |plugin, "jQuery Timepicker | |Addon," when adding time | |selection to the widget. | |This additional plugin has | |not been updated for many | |years. The new library, | |Flatpickr, will eventually | |replace both the jQuery | |Timepicker Addon and the | |jQueryUI datepicker widget. | |This replacement process | |begins here with the new | |Flatpickr calendar widget | |being added to Circulation | |-> Renew, Reports -> Patron | |statistics wizard, and | |Administration -> Patron | |categories. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28928 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28928 [Bug 28928] Minor follow-ups to Bug 28376 - Flatpickr introduction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 124368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124368&action=edit Bug 28928: Minor follow-ups to Bug 28376 - Flatpickr introduction This patch corrects three errors in the original Flatpickr introduction patch: - Missing document.ready() in borrowers_stats.tt. - Redundant calendarFirstDayOfWeek setting in caregories.js - Missing preventDefault() in calendar.inc The first two issues don't appear to cause any malfunction but are best practices. The third issue can cause the page to scroll unexpectedly. To reproduce this bug, go to (for instance) Administration -> Patron categories -> New category. - If necessary, narrow the height of your browser window so that there is a vertical scrollbar. - Scroll down the page so that the "Until date" field is at the top. - Click the "X" next to the field. - The page will scroll to the top. Apply the patch and test again. The page jump should not occur. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124368|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 [Bug 28942] Use Flatpickr on acquisitions pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28945 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945 [Bug 28945] Use Flatpickr on administration pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28949 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949 [Bug 28949] Use Flatpickr on reports pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28958 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28958 [Bug 28958] Use Flatpickr on serials pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28961 [Bug 28961] Use Flatpickr on tools pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963 [Bug 28963] Use Flatpickr on calendar page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28978 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28978 [Bug 28978] Convert installer CSS to SCSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 [Bug 28982] Use Flatpickr on onboarding pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983 [Bug 28983] Use Flatpickr on various pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28958 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28958 [Bug 28958] Use Flatpickr on serials pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28961 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28961 [Bug 28961] Use Flatpickr on tools pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28949 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28949 [Bug 28949] Use Flatpickr on reports pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28945 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28945 [Bug 28945] Use Flatpickr on administration pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28942 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 [Bug 28942] Use Flatpickr on acquisitions pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28982 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28982 [Bug 28982] Use Flatpickr on onboarding pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28963 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963 [Bug 28963] Use Flatpickr on calendar page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28983 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28983 [Bug 28983] Use Flatpickr on various pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29222 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29228 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 [Bug 29228] Use Flatpickr on offline circulation page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace obsolete |Flatpickr introduction for |jquery-ui-timepicker-addon |datetime picker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org Component|Templates |Staff Client -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Templates Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127627&action=edit Bug 28376: (follow-up) Replace jQueryUI date/timepicker with Flatpickr Remove uneeded include of flatpickr.min.js (we load it from calendar.inc) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #19)
Created attachment 127627 [details] [review] Bug 28376: (follow-up) Replace jQueryUI date/timepicker with Flatpickr
Remove uneeded include of flatpickr.min.js (we load it from calendar.inc)
Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29837 [Bug 29837] JS error during installer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29228 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 [Bug 29228] Use Flatpickr on offline circulation page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33886 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org