[Bug 32964] New: OPACResultsMaxItemsUnavailable description is misleading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Bug ID: 32964 Summary: OPACResultsMaxItemsUnavailable description is misleading Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Currently, the description for OPACResultsMaxItemsUnavailable is "show no more than X (unavailable) individual items for categories like Checked out, Damaged, On Hold, but only when you group them by branch." My problem is with the part "but only when you group them by branch." The options for OPACResultsUnavailableGroupingBy are - branch and substatus - branch only - substatus only If you don't know the values in the database for each of these, "but only when you group them by branch" seems to say either "branch only" or "branch and substatus" could work since they both group by branch. However, OPACResultsMaxItemsUnavailable only works if OPACResultsUnavailableGroupingBy is set to 'branch and substatus'. The two other options disable OPACResultsMaxItemsUnavailable completely. I think we should change this last part of the sentence by "but only if OPACResultsUnavailableGroupingBy is set to 'branch and substatus'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Terminology also says we should use 'library' instead of 'branch'. https://wiki.koha-community.org/wiki/Terminology#B -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31047 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 146655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146655&action=edit Bug 32964: OPACResultsMaxItemsUnavailable description is misleading This patch rephrases the last part of the description of the OPACResultsMaxItemsUnavailable system preference to clarify the link to the OPACResultsUnavailableGroupingBy option. It also changes some terminology to follow the guidelines (capitalization, library instead of branch). To test: 1. Apply patch 2. Go to Administration > Global system preferences 3. Search for OPACResultsMaxItems 4. Read the sentence for OPACResultsMaxItemsUnavailable, make sure it makes sense, the grammar and spelling are ok, respects terminology and capitalization guidelines 5. Try the link in the description, make sure it goes to the correct syspref 6. Read the sentence and options for OPACResultsUnavailableGroupingBy, make sure it makes sense, the grammar and spelling are ok, respects terminology and capitalization guidelines 7. Optionally, try the various options, they should still work as intended -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #2)
Created attachment 146655 [details] [review] Bug 32964: OPACResultsMaxItemsUnavailable description is misleading
This patch rephrases the last part of the description of the OPACResultsMaxItemsUnavailable system preference to clarify the link to the OPACResultsUnavailableGroupingBy option.
It also changes some terminology to follow the guidelines (capitalization, library instead of branch).
To test: 1. Apply patch 2. Go to Administration > Global system preferences 3. Search for OPACResultsMaxItems 4. Read the sentence for OPACResultsMaxItemsUnavailable, make sure it makes sense, the grammar and spelling are ok, respects terminology and capitalization guidelines 5. Try the link in the description, make sure it goes to the correct syspref 6. Read the sentence and options for OPACResultsUnavailableGroupingBy, make sure it makes sense, the grammar and spelling are ok, respects terminology and capitalization guidelines 7. Optionally, try the various options, they should still work as intended
The terminology and grammar makes sense to me. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146655|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 147983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147983&action=edit Bug 32964: OPACResultsMaxItemsUnavailable description is misleading This patch rephrases the last part of the description of the OPACResultsMaxItemsUnavailable system preference to clarify the link to the OPACResultsUnavailableGroupingBy option. It also changes some terminology to follow the guidelines (capitalization, library instead of branch). To test: 1. Apply patch 2. Go to Administration > Global system preferences 3. Search for OPACResultsMaxItems 4. Read the sentence for OPACResultsMaxItemsUnavailable, make sure it makes sense, the grammar and spelling are ok, respects terminology and capitalization guidelines 5. Try the link in the description, make sure it goes to the correct syspref 6. Read the sentence and options for OPACResultsUnavailableGroupingBy, make sure it makes sense, the grammar and spelling are ok, respects terminology and capitalization guidelines 7. Optionally, try the various options, they should still work as intended Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147983|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148637&action=edit Bug 32964: OPACResultsMaxItemsUnavailable description is misleading This patch rephrases the last part of the description of the OPACResultsMaxItemsUnavailable system preference to clarify the link to the OPACResultsUnavailableGroupingBy option. It also changes some terminology to follow the guidelines (capitalization, library instead of branch). To test: 1. Apply patch 2. Go to Administration > Global system preferences 3. Search for OPACResultsMaxItems 4. Read the sentence for OPACResultsMaxItemsUnavailable, make sure it makes sense, the grammar and spelling are ok, respects terminology and capitalization guidelines 5. Try the link in the description, make sure it goes to the correct syspref 6. Read the sentence and options for OPACResultsUnavailableGroupingBy, make sure it makes sense, the grammar and spelling are ok, respects terminology and capitalization guidelines 7. Optionally, try the various options, they should still work as intended Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Intrigued by this report. I have the impression that you found a bug in the group by library option. As it once worked differently :) We are now renaming according to current behavior. Digging a bit furthere here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #7)
Intrigued by this report. I have the impression that you found a bug in the group by library option. As it once worked differently :) We are now renaming according to current behavior. Digging a bit furthere here.
No, I must be wrong. The comments in the XSLT code are clear enough. But the description on the pref is confusing indeed. Caroline: What do you think of the additional rewording in the follow-up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 148821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148821&action=edit Bug 32964: (follow-up) Additional rewording for XSLT item display Test plan: Check OPAC preferences, OPACResultsMaxItems and siblings. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- <caroline> marcelr, the diff looks good to me, I'll sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148821|0 |1 is obsolete| | --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 148919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148919&action=edit Bug 32964: (follow-up) Additional rewording for XSLT item display Test plan: Check OPAC preferences, OPACResultsMaxItems and siblings. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I signed off the followup, but I can't change the status back to Signed off. I'm not sure what the correct procedure is here. Thanks again Marcel! Caroline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Caroline Cyr La Rose from comment #12)
I signed off the followup, but I can't change the status back to Signed off. I'm not sure what the correct procedure is here.
Thanks again Marcel!
Caroline
This is fine. Thanks. I added the additional work keyword to alert the RM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. Thanks everyone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org