[Bug 37399] New: Itemtype not displayed on holdings table if noItemTypeImages is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Bug ID: 37399 Summary: Itemtype not displayed on holdings table if noItemTypeImages is disabled Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl If syspref "noItemTypeImages" is disabled, holdings table won't display itemtype column. To reproduce: 1. Enable syspref "noItemTypeImages". 2. Find biblio with items. => Note that itemtype column is displayed on holdings table. 3. Disable syspref "noItemTypeImages". => Itemtype column is no longer displayed on holdings table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 169126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169126&action=edit Bug 37399: Fix showing itemtype on holdings table If syspref "noItemTypeImages" is disabled, holdings table won't display itemtype column. This patch fixes this. To reproduce: 1. Enable syspref "noItemTypeImages". 2. Find biblio with items. => Note that itemtype column is displayed on holdings table. 3. Disable syspref "noItemTypeImages". => Itemtype column is no longer displayed on holdings table. 4. Apply this patch. => Now column should be displayed correctly. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169126|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169150&action=edit Bug 37399: Fix showing itemtype on holdings table If syspref "noItemTypeImages" is disabled, holdings table won't display itemtype column. This patch fixes this. To reproduce: 1. Enable syspref "noItemTypeImages". 2. Find biblio with items. => Note that itemtype column is displayed on holdings table. 3. Disable syspref "noItemTypeImages". => Itemtype column is no longer displayed on holdings table. 4. Apply this patch. => Now column should be displayed correctly. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've changed the bug type to "normal" from "enhancement", as it is something that isn't working when it should. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169150|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 169230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169230&action=edit Bug 37399: Fix showing itemtype on holdings table If syspref "noItemTypeImages" is disabled, holdings table won't display itemtype column. This patch fixes this. To reproduce: 1. Enable syspref "noItemTypeImages". 2. Find biblio with items. => Note that itemtype column is displayed on holdings table. 3. Disable syspref "noItemTypeImages". => Itemtype column is no longer displayed on holdings table. 4. Apply this patch. => Now column should be displayed correctly. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the staff release notes| |interface holdings table | |for a record so that the | |'Item type' column is | |displayed when the | |"noItemTypeImages" system | |preference is set to 'Don't | |show'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Itemtype not displayed on |Item type not displayed on |holdings table if |holdings table if |noItemTypeImages is |noItemTypeImages is |disabled |disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate CC| |aleisha@catalyst.net.nz --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- This fixes a bug for the holdings table in the staff interface in 24.05. If noItemTypeImages is disabled, we get the "Processing" box for a while, and in the console is an error: `Uncaught ReferenceError: item_type_description is not defined` This patches moves the important line outside of the [% UNLESS %] block: `let item_type_description = row._strings.item_type_id.str;` so that item_type_description can be defined. Please backport :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.04 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |33568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the staff biblio detail view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 33568 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37399 Bug 37399 depends on bug 33568, which changed state. Bug 33568 Summary: Use the REST API to display items on the staff biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org