https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51394|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 51395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51395&action=edit Bug 16496 - accountlines.issue_id not set when new overdue is processed It appears that somehow the adding of issue_id to accountlines for new fines was missed! This is incredibly important, otherwise UpdateFine will always create a new fine! Test Plan: 1) Create a new overdue checkout 2) Run fines.pl to generate an accountline for it 3) Note it has no issue_id 4) Apply this patch 5) Repeat steps 1 and 2 6) Note it now has an issue_id! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Depends on| |13790 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Ahh looks like this was missed when bug 13790 was done, will test now Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 [Bug 13790] Add unique id issue_id to issues and old_issues tables -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51395|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 51397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51397&action=edit Bug 16496 - accountlines.issue_id not set when new overdue is processed It appears that somehow the adding of issue_id to accountlines for new fines was missed! This is incredibly important, otherwise UpdateFine will always create a new fine! Test Plan: 1) Create a new overdue checkout 2) Run fines.pl to generate an accountline for it 3) Note it has no issue_id 4) Apply this patch 5) Repeat steps 1 and 2 6) Note it now has an issue_id! Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51397|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51399&action=edit Bug 16496 - accountlines.issue_id not set when new overdue is processed It appears that somehow the adding of issue_id to accountlines for new fines was missed! This is incredibly important, otherwise UpdateFine will always create a new fine! Test Plan: 1) Create a new overdue checkout 2) Run fines.pl to generate an accountline for it 3) Note it has no issue_id 4) Apply this patch 5) Repeat steps 1 and 2 6) Note it now has an issue_id! Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16496 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for the 16.05 release! Thanks for the unit test Jonathan! -- You are receiving this mail because: You are watching all bug changes.