http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14706&action=edit Bug 9424 - Move JavaScript out of header include This patch removes JavaScript "onlick" attributes from header.inc and moves the functionality to staff-global.js. This is in keeping with the idea of progressive enhancement. This patch also makes a couple of minor changes to staff-global.js to fix jsHint warnings. To test, be sure to clear your browser cache after applying the patch. Test the logout link under several conditions: - intranetbookbag enabled, virtualshelves enabled - intranetbookbag enabled, virtualshelves disabled - intranetbookbag disabled, virtualshelves enabled - intranetbookbag disabled, virtualshelves disabled Logout should be successful with no JavaScript errors. This array of tests is required because of the Cart-clearing action of logging out and the changes made in this patch to the way Car/Lists JavaScript is included. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15101|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15191&action=edit Bug 9424 - Move JavaScript out of header include This patch removes JavaScript "onlick" attributes from header.inc and moves the functionality to staff-global.js. This is in keeping with the idea of progressive enhancement. This patch also makes a couple of minor changes to staff-global.js to fix jsHint warnings. To test, be sure to clear your browser cache after applying the patch. Test the logout link under several conditions: - intranetbookbag enabled, virtualshelves enabled - intranetbookbag enabled, virtualshelves disabled - intranetbookbag disabled, virtualshelves enabled - intranetbookbag disabled, virtualshelves disabled Logout should be successful with no JavaScript errors. This array of tests is required because of the Cart-clearing action of logging out and the changes made in this patch to the way Car/Lists JavaScript is included. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch does not apply, could you rebase it please? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18062|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18358&action=edit Bug 9424 [Revised] Move JavaScript out of header include This patch removes JavaScript "onlick" attributes from header.inc and moves the functionality to staff-global.js. This is in keeping with the idea of progressive enhancement. To test, be sure to clear your browser cache after applying the patch. - Test the help link. - Test the logout link with the intranetbookbag preference on and off. - Open a patron's account and click "search to hold." Log out, and log in again. Koha should not remember the patron you chose before logging out (as seen from a search results page). Revised for current master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18358|0 |1 is obsolete| | --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 18391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18391&action=edit Bug 9424: Move JavaScript out of header include This patch removes JavaScript "onlick" attributes from header.inc and moves the functionality to staff-global.js. This is in keeping with the idea of progressive enhancement. To test, be sure to clear your browser cache after applying the patch. - Test the help link. - Test the logout link with the intranetbookbag preference on and off. - Open a patron's account and click "search to hold." Log out, and log in again. Koha should not remember the patron you chose before logging out (as seen from a search results page). Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18391|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18408&action=edit Bug 9424: Move JavaScript out of header include This patch removes JavaScript "onlick" attributes from header.inc and moves the functionality to staff-global.js. This is in keeping with the idea of progressive enhancement. To test, be sure to clear your browser cache after applying the patch. - Test the help link. - Test the logout link with the intranetbookbag preference on and off. - Open a patron's account and click "search to hold." Log out, and log in again. Koha should not remember the patron you chose before logging out (as seen from a search results page). Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.