http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8899 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12794|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12896&action=edit Bug 8899 - Remove unused CSS declarations from staff client CSS Using an add-on for Firefox called CSS Usage I found some instances of CSS in staff-global.css which are unused. Unused selectors were confirmed by a search of the code. Testers can't exactly check the whole staff client for things which look off, but can confirm by their own search that the removed CSS has no corresponding markup. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8899 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- I see 2 rules already in use: members/moremember.tt: <span class="problem"><a href="/cgi-bin/koha/members/member-password.pl?member=[% borrowernumber %]">Undefined</a></span> modules/reports/guided_reports_start.tt: $(this).parents('tr').attr("class","warn"); -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8899 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #4)

already or still in use ? Yes, sorry :-/

does it mean failed QA ? No, it is not failed QA, but I would like to have the Owen's point of view. If I drop the "Signed off" status, others QAers will not be able to give their opinion afterwards.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12896|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13174&action=edit Bug 8899 [Revised] Remove unused CSS declarations from staff client CSS Using an add-on for Firefox called CSS Usage I found some instances of CSS in staff-global.css which are unused. Unused selectors were confirmed by a search of the code. Testers can't exactly check the whole staff client for things which look off, but can confirm by their own search that the removed CSS has no corresponding markup. Revision adds back lines which were discoverd by QA to be in use. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13174|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13356&action=edit [SIGNED-OFF] Bug 8899 [Revised] Remove unused CSS declarations from staff client CSS Using an add-on for Firefox called CSS Usage I found some instances of CSS in staff-global.css which are unused. Unused selectors were confirmed by a search of the code. Testers can't exactly check the whole staff client for things which look off, but can confirm by their own search that the removed CSS has no corresponding markup. Revision adds back lines which were discoverd by QA to be in use. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8899 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Looks good now. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.