[Bug 37615] New: Clean up the form for sending cardnumbers from a report to batch patron modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 Bug ID: 37615 Summary: Clean up the form for sending cardnumbers from a report to batch patron modification Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: phil@chetcolibrary.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org Depends on: 37197 Followup to bug 37197, because I wrote the patch there based on reverting the changes from the wrong CSRF patch - https://git.koha-community.org/Koha-community/Koha/commit/8a20e0cb6a0efd6b99... changed it from a POST to cud-show into a GET of show, but then later on https://git.koha-community.org/Koha-community/Koha/commit/21fa3f64c31dad23e5... tried to make that actually work by switching from a textarea to a (long) list of inputs, which isn't needed now that we've gone back to a POST. It should just be a textarea like the other POSTed lists of numbers. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37197 [Bug 37197] Batch patron modification from reports fails by using GET instead of POST -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 170413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170413&action=edit Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification Since bug 37197 switched reports back to using a POST to send cardnumbers to batch modification, we should also be using a single textarea rather than multiple inputs. Test plan: 1. Reports - Create from SQL - give it a name, and the SQL select cardnumber from borrowers limit 3 2. Save report - Run report 3. Batch operations with 3 visible records - Batch patron modification 4. Verify that you have the same three cardnumbers in Batch patron modification as were in the report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170413|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 170420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170420&action=edit Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification Since bug 37197 switched reports back to using a POST to send cardnumbers to batch modification, we should also be using a single textarea rather than multiple inputs. Test plan: 1. Reports - Create from SQL - give it a name, and the SQL select cardnumber from borrowers limit 3 2. Save report - Run report 3. Batch operations with 3 visible records - Batch patron modification 4. Verify that you have the same three cardnumbers in Batch patron modification as were in the report. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I have signed off. However, I noticed no visible difference before and after the patch was applied - and everything worked as expected, both before and after. Could you explain what is actually changing here - I don't see a text area, so the patch description does not make any sense to me. If there is nothing visible that changes when testing and that everything should work as expected (both before and after the patch), it would be useful to say that (for us mere mortals that don't necessarily understand developer speak!). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- If you want to see the difference, you can view source on the report results page, and search for modborrowers.pl - before you'll see three <input>s, after you'll see one <textarea>. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170420|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 170447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170447&action=edit Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification Since bug 37197 switched reports back to using a POST to send cardnumbers to batch modification, we should also be using a single textarea rather than multiple inputs. Test plan: 1. Reports - Create from SQL - give it a name, and the SQL select cardnumber from borrowers limit 3 2. Save report - Run report 3. Batch operations with 3 visible records - Batch patron modification 4. Verify that you have the same three cardnumbers in Batch patron modification as were in the report. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This tidies up the form release notes| |used when initiating patron | |batch modifications from a | |report that uses card | |numbers (option for 'Batch | |operations with X visible | |records'). There is no | |visible difference (the | |form that sends the card | |numbers to the patron batch | |modification form now puts | |them in a single text area, | |instead of multiple | |inputs). --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Phil Ringnalda from comment #4)
If you want to see the difference, you can view source on the report results page, and search for modborrowers.pl - before you'll see three <input>s, after you'll see one <textarea>.
Thanks for explaining! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 Bug 37615 depends on bug 37197, which changed state. Bug 37197 Summary: Batch patron modification from reports fails by using GET instead of POST https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37197 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37615 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 24.05.x, no backport unless rebased. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org