[Bug 13193] Make Memcached usage fork safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #24 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Martin Renvoize from comment #23)
I'm wondering if it's worthwhile effectively porting the test from Cache::Memcached::Fast::Safe for forking: https://metacpan.org/source/KAZEBURO/Cache-Memcached-Fast-Safe-0.06/t/ 02_fork.t.
It doesn't test our particular case, but, assuming it's right, should catch cases of missed calls to disconnect_all (which ::Safe does for us here).. in that way we should catch failures if someone down the line decides to remove the ::Safe module without fully understanding why we were using it.
Thoughts?
or would it be enough to add a comment on top of the line +my $memcached = Cache::Memcached::Fast::Safe->new( Stating that it is a fork safe memcached module? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org