[Bug 29230] New: borrowers.borrowernotes and borrowers.opacnote fields won’t display in the HOLD_SLIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Bug ID: 29230 Summary: borrowers.borrowernotes and borrowers.opacnote fields won’t display in the HOLD_SLIP Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: marie-luce.laflamme@inlibro.com QA Contact: testopia@bugs.koha-community.org If you add borrowers.borrowernotes and borrowers.opacnote fields in the HOLD_SLIP template, Koha won’t print out the patron account notes on the slip. Test 1. Add borrowers.borrowernotes and borrowers.opacnote fields in the HOLD_SLIP template (Tools > Notices & slips) 2. Add a borrowernotes, then an opacnote in a patron account 3. Place an item on hold 4. Check-in the item 5. Select the «print slip…» option to confirm the hold Unfortunately, these two fields are not displayed on the slip. It would be nice to see the borrowernotes since some libraries use this field to add details about patron special needs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I've tried right now on master with <<borrowers.borrowernotes>> and it's working. Which version of Koha are you using? Did you confirm the problem on a sandbox? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #2 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- (In reply to Jonathan Druart from comment #1) I've tried the master, the branch 20.05 and the PTFS-E Sandboxes. Unfortunately, none of them could print the borrowers.borrowernotes and borrowers.opacnote fields. Prior to my test, I did add the following terms in the HOLD_SLIP template email and print tabs: intranet notes: <<borrowers.borrowernotes>> opac notes: <<borrowers.opacnote>> The reserves.notes works fine, but the other note fields aren't showing up on the slip. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Go to http://staff-flame.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/circ/returns.pl Check in 39999000004731, click "print slip, transfer, and confirm" => You see the note What did you try? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #4 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- (In reply to Jonathan Druart from comment #3)
Go to http://staff-flame.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/circ/returns.pl
Check in 39999000004731, click "print slip, transfer, and confirm"
=> You see the note
What did you try?
Hi Jonathan, You're right, I can see your notes. My mistakes. After a recheck, I was testing with the intranet_message or opac_message fields, not the borrowers.*notes. sorry for the confusion Is there a way to add a borrowers message on the hold slip? thanks in the same sandboxe try to return 39999000003154 for this patron 23529000120056 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|borrowers.borrowernotes and |borrowers.borrowernotes and |borrowers.opacnote fields |borrowers.opacnote fields |won’t display in the |won't display in the |HOLD_SLIP |HOLD_SLIP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126641&action=edit Bug 29230: Add Koha::Patron->messages Add methods to return the messages attached to a patron. It will add the capability to access them from notice templates. Test plan: Define some messages for a given patron Go to the circulation page of the patron and confirm that they are still displayed Test the notice templates: Add to HOLD_SLIP the following content """ [% SET messages = borrower.messages %] [% IF messages.count %] Messages: <ul> [% FOR m IN messages.search( message_type => 'L' ) %] <li>[% m.message %]</li> [% END %] </ul> [% END %] """ To display all the messages from staff ('L') Adapt following your needs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|borrowers.borrowernotes and |Patron's messages not |borrowers.opacnote fields |accessible from template |won't display in the |notices |HOLD_SLIP | Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patch adds what's needed to access the messages from notice templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126641|0 |1 is obsolete| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 127678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127678&action=edit Bug 29230: Add Koha::Patron->messages Add methods to return the messages attached to a patron. It will add the capability to access them from notice templates. Test plan: Define some messages for a given patron Go to the circulation page of the patron and confirm that they are still displayed Test the notice templates: Add to HOLD_SLIP the following content """ [% SET messages = borrower.messages %] [% IF messages.count %] Messages: <ul> [% FOR m IN messages.search( message_type => 'L' ) %] <li>[% m.message %]</li> [% END %] </ul> [% END %] """ To display all the messages from staff ('L') Adapt following your needs. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127678|0 |1 is obsolete| | --- Comment #8 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 128162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128162&action=edit Bug 29230: Add Koha::Patron->messages Add methods to return the messages attached to a patron. It will add the capability to access them from notice templates. Test plan: Define some messages for a given patron Go to the circulation page of the patron and confirm that they are still displayed Test the notice templates: Add to HOLD_SLIP the following content """ [% SET messages = borrower.messages %] [% IF messages.count %] Messages: <ul> [% FOR m IN messages.search( message_type => 'L' ) %] <li>[% m.message %]</li> [% END %] </ul> [% END %] """ To display all the messages from staff ('L') Adapt following your needs. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Stina Hallin <stina.hallin@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stina.hallin@ub.lu.se --- Comment #9 from Stina Hallin <stina.hallin@ub.lu.se> --- Signed off using a sandbox. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl, | |tomascohen@gmail.com --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Although it looks good to me on itself, we have a clash with Koha::Object::messages. cc: Tomas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #10)
Although it looks good to me on itself, we have a clash with Koha::Object::messages.
cc: Tomas
In my opinion Koha::Object->messages should be renamed. ->_messages maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #11)
(In reply to Marcel de Rooy from comment #10)
Although it looks good to me on itself, we have a clash with Koha::Object::messages.
cc: Tomas
In my opinion Koha::Object->messages should be renamed. ->_messages maybe?
Maybe, but you need to think of an accessor? Or maybe bug 29746 is the way to avoid it completely? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29785 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I opened bug 29785 to rename it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 [Bug 29785] Koha::Object->messages must be renamed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Marcel, let me know if you are not going to work on this one in a short term, please. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #14)
Marcel, let me know if you are not going to work on this one in a short term, please. Thanks!
Thanks for your patience. I will have another look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Back to blocked: base report fails qa. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128162|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130044&action=edit Bug 29230: Add Koha::Patron->messages Add methods to return the messages attached to a patron. It will add the capability to access them from notice templates. Test plan: Define some messages for a given patron Go to the circulation page of the patron and confirm that they are still displayed Test the notice templates: Add to HOLD_SLIP the following content """ [% SET messages = borrower.messages %] [% IF messages.count %] Messages: <ul> [% FOR m IN messages.search( message_type => 'L' ) %] <li>[% m.message %]</li> [% END %] </ul> [% END %] """ To display all the messages from staff ('L') Adapt following your needs. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130044|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 130097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130097&action=edit Bug 29230: Add Koha::Patron->messages Add methods to return the messages attached to a patron. It will add the capability to access them from notice templates. Test plan: Define some messages for a given patron Go to the circulation page of the patron and confirm that they are still displayed Test the notice templates: Add to HOLD_SLIP the following content """ [% SET messages = borrower.messages %] [% IF messages.count %] Messages: <ul> [% FOR m IN messages.search( message_type => 'L' ) %] <li>[% m.message %]</li> [% END %] </ul> [% END %] """ To display all the messages from staff ('L') Adapt following your needs. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Do we actually have a rule for empty test descriptions? :) # Subtest: messages 1..4 ok 1 - No message yet ok 2 - There are two messages for this patron ok 3 ok 4 ok 14 - messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #19)
Do we actually have a rule for empty test descriptions? :)
IMO the descriptions are like comments, they should be there when it's not obvious. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30099 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30099 [Bug 30099] Error when accessing circulation.pl without patron parameter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Doesn't apply cleanly to 21.05, please rebase if needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29230 Bug 29230 depends on bug 29785, which changed state. Bug 29785 Summary: Koha::Object->messages must be renamed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29785 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org