[Bug 18089] New: All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Bug ID: 18089 Summary: All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Due to the way it has been implemented, singleBranchMode is set to an empty string rather than 0 if there is only one branch. This causes any block that tests for singleBranchMOde to be 0 to never appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60055&action=edit Bug 18089 - Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60056&action=edit Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch Due to the way it has been implemented, singleBranchMode is set to an empty string rather than 0 if there is only one branch. This causes any block that tests for singleBranchMOde to be 0 to never appear. Test Plan: 1) Apply this patch set 2) prove t/XSLT.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60055|0 |1 is obsolete| | Attachment #60056|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60059&action=edit [SIGNED-OFF] Bug 18089 - Unit test Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60060&action=edit [SIGNED-OFF] Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch Due to the way it has been implemented, singleBranchMode is set to an empty string rather than 0 if there is only one branch. This causes any block that tests for singleBranchMOde to be 0 to never appear. Test Plan: 1) Apply this patch set 2) prove t/XSLT.t Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60059|0 |1 is obsolete| | Attachment #60060|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60061&action=edit [SIGNED-OFF] Bug 18089 - Unit test Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60062&action=edit [SIGNED-OFF] Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch Due to the way it has been implemented, singleBranchMode is set to an empty string rather than 0 if there is only one branch. This causes any block that tests for singleBranchMOde to be 0 to never appear. Test Plan: 1) Apply this patch set 2) prove t/XSLT.t Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60061|0 |1 is obsolete| | Attachment #60062|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60065&action=edit Bug 18089 - Unit test Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60066&action=edit Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch Due to the way it has been implemented, singleBranchMode is set to an empty string rather than 0 if there is only one branch. This causes any block that tests for singleBranchMOde to be 0 to never appear. Test Plan: 1) Apply this patch set 2) prove t/XSLT.t Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60067&action=edit Bug 18089: Remove warnings from tests using DBIx::Class fixtures Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #12 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.10 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org