[Bug 40873] New: AV dropdowns in OPAC don't use lib_opac values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 Bug ID: 40873 Summary: AV dropdowns in OPAC don't use lib_opac values Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: ephetteplace@cca.edu QA Contact: testopia@bugs.koha-community.org The OPAC version of av-build-dropbox.inc uses av.lib instead of av.lib_opac so even if your AV category has OPAC-friendly text it is not used. I discovered this specifically when using the SUGGEST_FORMAT item types for purchase suggestions. I created the category, added several values, gave them all a concise "lib" value and some a more explanatory "lib_opac" value. When I visited the OPAC's suggestions page /cgi-bin/koha/opac-suggestions.pl?op=add_form I saw the form only used the "lib" values. The code is in koha-tmpl/opac-tmpl/bootstrap/en/includes/av-build-dropbox.inc I suspect many patron-facing AVs don't have lib_opac values because they're not used anywhere, so changing the dropbox code to use lib_opac could have negative side effects for many existing instances. Would it make sense to check if an AV has lib_opac, use that, and default to lib if not available? This should make the transition seamless, unless libraries put inaccurate values in their lib_opac which they wouldn't notice until now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 --- Comment #1 from Eric Phetteplace <ephetteplace@cca.edu> --- Well I see why I discovered this on the purchase suggestions, that appears to be the only place the OPAC av-build-dropbox.inc is used. But if this include is used again in the future, it would really be nice if it worked with the lib_opac values. Patch forthcoming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |ephetteplace@cca.edu Severity|enhancement |minor Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 --- Comment #2 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 186901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186901&action=edit Bug 40873: AV dropdowns in OPAC don't use lib_opac To test (ktd): - Sign into the admin side - Go to Administration > Authorized Values - Edit or add to SUGGEST_FORMAT such that one AV has a different lib_opac - Sign into the public catalog - Go to purchase suggestions /cgi-bin/koha/opac-suggestions.pl?op=add_form - Note that the AV in the 'Item type' dropdown does not use your lib_opac text - Apply the patch and refresh the page - Now the AV uses the lib_opac text Sponsored-By: California College of the Arts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186901|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 190002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190002&action=edit Bug 40873: AV dropdowns in OPAC don't use lib_opac To test (ktd): - Sign into the admin side - Go to Administration > Authorized Values - Edit or add to SUGGEST_FORMAT such that one AV has a different lib_opac - Sign into the public catalog - Go to purchase suggestions /cgi-bin/koha/opac-suggestions.pl?op=add_form - Note that the AV in the 'Item type' dropdown does not use your lib_opac text - Apply the patch and refresh the page - Now the AV uses the lib_opac text Sponsored-By: California College of the Arts Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the value release notes| |displayed in dropdown lists | |for authorized values in | |the OPAC. The value entered | |in the 'Description (OPAC)' | |field is now shown for | |authorized value dropdown | |lists. Previously, the | |value shown was what was in | |the 'Description' field. | | | |Example: for the | |SUGGEST_FORMAT authorized | |value category, the value | |in 'Description (OPAC)' is | |now shown in the dropdown | |list for the item type | |field on the purchase | |suggestion form in the | |OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com CC| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190002|0 |1 is obsolete| | --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 190026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190026&action=edit Bug 40873: AV dropdowns in OPAC don't use lib_opac To test (ktd): - Sign into the admin side - Go to Administration > Authorized Values - Edit or add to SUGGEST_FORMAT such that one AV has a different lib_opac - Sign into the public catalog - Go to purchase suggestions /cgi-bin/koha/opac-suggestions.pl?op=add_form - Note that the AV in the 'Item type' dropdown does not use your lib_opac text - Apply the patch and refresh the page - Now the AV uses the lib_opac text Sponsored-By: California College of the Arts Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.06 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.06 |25.11.00,25.05.06,24.11.11 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #7)
Pushed to 24.11.x for 24.11.11
Pushed a fix to make Jenkins happy : Bug 40873: [24.11.x] Use valid TT syntax -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40873 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #10 from David Nind <david@davidnind.com> --- Bug fix, no change to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org