https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |frederic@tamil.fr --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- This is an very annoying regression when using ES. You're right to point the facet building process. I don't think filtering facets is a good option. It isn't correct already with Zebra. With ES, since there is a separate field for facets (fieldname__facet), this could be done differently. For ES, we could disable see forms extraction from: Filter::MARC::EmbedSeeFromHeadings and rather delegate populating ES fields with see forms to: Koha::SearchEngine::ElasticSearch::marc_records_to_documents This way fieldname__facet fields could be populating only with heading, skipping all see forms (put only in fieldname field). Does it sound correct to you? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Frédéric Demians from comment #1)

This is an very annoying regression when using ES. You're right to point the facet building process. I don't think filtering facets is a good option. It isn't correct already with Zebra. With ES, since there is a separate field for facets (fieldname__facet), this could be done differently.

For ES, we could disable see forms extraction from: Filter::MARC::EmbedSeeFromHeadings and rather delegate populating ES fields with see forms to: Koha::SearchEngine::ElasticSearch::marc_records_to_documents

This way fieldname__facet fields could be populating only with heading, skipping all see forms (put only in fieldname field).

Does it sound correct to you?

I agree, Frederic. I was trying to understand how it got solved for ES and, to my dismay, I found it wasn't! And the same for availability filtering in my opinion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 113415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113415&action=edit Bug 25030: Implement IncludeSeeFromInSearches with Elasticsearch Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Disable syspref IncludeSeeFromInSearches 4. Reindex the biblio. You should be able to find it when searching 'Foo' but not when searching 'Bar' 5. Enable syspref IncludeSeeFromInSearches 6. Reindex the biblio. You should be able to find it when searching 'Foo' and also when searching 'Bar' 7. prove t/db_dependent/Koha/SearchEngine/Elasticsearch.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 e.betemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- Nice one Julian ! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118144|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 121001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121001&action=edit Bug 25030: Implement IncludeSeeFromInSearches with Elasticsearch Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Disable syspref IncludeSeeFromInSearches 4. Reindex the biblio. You should be able to find it when searching 'Foo' but not when searching 'Bar' 5. Enable syspref IncludeSeeFromInSearches 6. Reindex the biblio. You should be able to find it when searching 'Foo' and also when searching 'Bar' without the patch, 'Bar' doesn't yeld results. With it, it does. 7. prove t/db_dependent/Koha/SearchEngine/Elasticsearch.t Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121001|0 |1 is obsolete| | --- Comment #8 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 121036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121036&action=edit Bug 25030: Implement IncludeSeeFromInSearches with Elasticsearch Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Disable syspref IncludeSeeFromInSearches 4. Reindex the biblio. You should be able to find it when searching 'Foo' but not when searching 'Bar' 5. Enable syspref IncludeSeeFromInSearches 6. Reindex the biblio. You should be able to find it when searching 'Foo' and also when searching 'Bar' without the patch, 'Bar' doesn't yeld results. With it, it does. 7. prove t/db_dependent/Koha/SearchEngine/Elasticsearch.t Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 --- Comment #10 from Séverine Queune <severine.queune@bulac.fr> --- Hi everyone ! Any chance to see this patch updated soon ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121036|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126426&action=edit Bug 25030: Implement IncludeSeeFromInSearches with Elasticsearch Test plan: 1. Create an authority with at least a 1XX$a and a 4XX$a, for instance: 100 $a Foo 400 $a Bar 2. Create a biblio and add a link to this authority using the cataloguing plugin 3. Disable syspref IncludeSeeFromInSearches 4. Reindex the biblio. You should be able to find it when searching 'Foo' but not when searching 'Bar' 5. Enable syspref IncludeSeeFromInSearches 6. Reindex the biblio. You should be able to find it when searching 'Foo' and also when searching 'Bar' without the patch, 'Bar' doesn't yeld results. With it, it does. 7. prove t/db_dependent/Koha/SearchEngine/Elasticsearch.t Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #7)

'Can\'t locate Search/Elasticsearch/CxnPool/Fluid.pm in @INC (you may need to install the Search::Elasticsearch::CxnPool::Fluid module)

This Fluid module seems to not exists.

In t/db_dependent/Koha/SearchEngine/Elasticsearch.t line 110 if we change cxn_pool => 'Fluid' to cxn_pool => 'Fluid_LOL_LOL_LOL'

we get 'Can\'t locate Search/Elasticsearch/CxnPool/Fluid_LOL_LOL_LOL.pm in @INC (you may need to install the Search::Elasticsearch::CxnPool::Fluid_LOL_LOL_LOL module)

No idea what this means o_o

Well, the second makes sense, you have made up a moduel that doesn't exist :-) For the first, I suspect a configuration issue, I cannot recreate the failures (In reply to Victor Grousset/tuxayo from comment #9)

Not ready for QA, the two tests on sandboxes can't have ran the test and the test on comment 7 was a failure.

Cannot recreate, passing QA I will note, there is some duplicated code here, but I think fixing the issue is important, handling these fields separately makes sense. Could generate a subroutine with options in future, but I think this is straightforward and readable. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Tests are not passing for me either. Undefined subroutine &main::AddAuthority called at /kohadevbox/koha/t/db_dependent/Koha/SearchEngine/Elasticsearch.t line 874. then, after the following change: -use C4::AuthoritiesMarc; +use C4::AuthoritiesMarc qw( AddAuthority ); I get: # Failed test 'No tests run for subtest "Koha::SearchEngine::Elasticsearch::marc_records_to_documents with IncludeSeeFromInSearches"' # at /kohadevbox/koha/t/db_dependent/Koha/SearchEngine/Elasticsearch.t line 927. Can't use string ("Can't locate Search/Elasticsearc"...) as a HASH ref while "strict refs" in use at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 130. After the removing the try in update_index: Can't locate Search/Elasticsearch/CxnPool/Fluid.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126479&action=edit Bug 25030: (QA follow-up) Fix tests Fluid is not a valid value for cxn_pool - valid values are: Sniff,Static,NoPing AddAuthority call calls index - the indexing call was trying to access the ES server with mocked values and dying when they were invalid This patch uses a correct value for cxn_pool and inserts directly into DB to avoid indexing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works also for me, thanks all :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |Feature enabled by system release notes| |preference | |IncludeSeeFromInSearches | |was implemented in Zebra | |search engine but not in | |Elasticsearch. | |This feature | |allows in bibliographic | |searches to match also on | |authorities see from | |(non-preferred form) | |headings. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25028 -- You are receiving this mail because: You are watching all bug changes.