[Bug 35885] New: ERM vendor sort order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Bug ID: 35885 Summary: ERM vendor sort order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: Laura.escamilla@bywatersolutions.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com Currently the vendor drop-down list shows the vendors in the order that they were added to the Acquisitions module. It would be ideal if the vendors were sorted in alphabetical order so that libraries could easily locate their selection. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Jeremy Evans <jeremy.evans@ukhsa.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans@ukhsa.gov.uk --- Comment #1 from Jeremy Evans <jeremy.evans@ukhsa.gov.uk> --- We have come across this issue recently. As we have many more vendors in the system now the vendor drop down is not very useful as the entries are not displaying in alphabetical order. However if you start typing then the relevant entries will show up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177700&action=edit Bug 35885: Sort vendors by name by default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no Status|Needs Signoff |Failed QA --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Not sure if I am missing something here: - Set ERMModule = Enable - In the Acquisitions module I added 4 vendors, with names X, A, C, Y, in that order - Went to E-resource management > Agreements > New agreement - In the "Vendor" dropdpwn, the vendors are listed in the order they were entered, X, A, C, Y - Applied the patch + restart_all - Reloaded the "New agreement" page, but the vendors are listed in the same order, the order they were entered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Force reload to clear the browser's cache. You should see in the network tab: GET http://localhost:8081/api/v1/acquisitions/vendors?_per_page=-1&_order_by=name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- I have shift-reloaded, restarted the browser and tested in an incognito window, but the call I see being made is: http://localhost:8081/api/v1/acquisitions/vendors?_per_page=-1 without the "_order_by=name". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Sorry I always have it running so I forgot. You need to rebuild the JS: `yarn js:build` `yarn js:watch` will auto-rebuild when files are modified. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177700|0 |1 is obsolete| | --- Comment #7 from Magnus Enger <magnus@libriotech.no> --- Created attachment 177828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177828&action=edit Bug 35885: Sort vendors by name by default Signed-off-by: Magnus Enger <magnus@libriotech.no> To reproduce: - Set ERMModule = Enable - In the Acquisitions module I added 4 vendors, with names X, A, C, Y, in that order - Went to E-resource management > Agreements > New agreement - In the "Vendor" dropdown, the vendors are listed in the order they were entered: X, A, C, Y To test: - Applied the patch + restart_all + run "yarn js:build" in the cloned Koha repo inside KTD - Shift-reload the "New agreement" page - Vendors are in alphabetical order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177828|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178087&action=edit Bug 35885: Sort vendors by name by default Signed-off-by: Magnus Enger <magnus@libriotech.no> To reproduce: - Set ERMModule = Enable - In the Acquisitions module I added 4 vendors, with names X, A, C, Y, in that order - Went to E-resource management > Agreements > New agreement - In the "Vendor" dropdown, the vendors are listed in the order they were entered: X, A, C, Y To test: - Applied the patch + restart_all + run "yarn js:build" in the cloned Koha repo inside KTD - Shift-reload the "New agreement" page - Vendors are in alphabetical order Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Very happy about this one :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate CC| |clemens.tubach@kit.edu, | |michaela.sieber@kit.edu --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we please have this backported to 24.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35885 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org