[Bug 5301] New: In C4/XSLT.pm, itemcallnumber can contain special XML characters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5301 Summary: In C4/XSLT.pm, itemcallnumber can contain special XML characters Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: MARC Bibliographic data support AssignedTo: gmcharlt@gmail.com ReportedBy: daniel.latremoliere@bulac.fr QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Estimated Hours: 0.0 Created attachment 2686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2686 Simple patch (only for '<'). In C4/XSLT.pm itemcallnumber is concatenated with other data to create an XML document. Currently, only ampersand is encoded in corresponding XML entity (&). If itemcallnumber contain '<' then the XML parser, reading the XML document, can not understand the document, because it interprets this part of itemcallnumber data ('<') as the beginning of an XML tag. In this case (one bibliography with '<' in itemcallnumber) search in Koha does not function (return no results given the XML parsing bug). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5301 --- Comment #1 from Daniel Latrémolière <daniel.latremoliere@bulac.fr> 2010-10-13 14:28:37 UTC --- Created attachment 2687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2687 Complete patch (for all XML special characters except ampersand) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5301 Daniel Latrémolière <daniel.latremoliere@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2686|0 |1 is patch| | Attachment #2686|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5301 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|rel_3_2 |rel_3_4 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> 2010-10-27 12:24:57 UTC --- Submitted revised patch for inclusion in HEAD. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5301 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2686|0 |1 is obsolete| | Attachment #2687|0 |1 is obsolete| | --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> 2010-10-27 12:25:40 UTC --- Created attachment 2702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2702 revised patch; defines new C4::Koha::xml_escape -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5301 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5301 --- Comment #4 from Daniel Latrémolière <daniel.latremoliere@bulac.fr> 2010-10-28 07:34:13 UTC --- I have tested changes for the files C4/Koha.pm and C4/XSLT.pm without problems. It has good behaviour even on data containing '<'. This patch is vastly better than mine. Thank you very much for the clean refactoring.%0 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5301 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #4 from Daniel Latrémolière <daniel.latremoliere@bulac.fr> 2010-10-28 07:34:13 UTC --- I have tested changes for the files C4/Koha.pm and C4/XSLT.pm without problems. It has good behaviour even on data containing '<'. This patch is vastly better than mine. Thank you very much for the clean refactoring.%0 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2010-11-01 19:35:08 UTC --- Pushed to branch new/bug_5301 Please test and let me know and I will merge to master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5301 --- Comment #6 from Daniel Latrémolière <daniel.latremoliere@bulac.fr> 2010-11-02 12:45:22 UTC ---
Pushed to branch new/bug_5301
Please test and let me know and I will merge to master.
I have tested branch new/bug_5301. Koha's behaviour is good, even on data containing '<'. Thanks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5301 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2010-11-02 17:57:59 UTC --- Pushed to master, please close if still working fine -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5301 Daniel Latrémolière <daniel.latremoliere@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5301 --- Comment #8 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-11-18 03:15:10 UTC --- This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5301 Daniel Latrémolière <daniel.latremoliere@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org