[Bug 9499] New: --itemscontent= option is undocumented in advanced-notice.pl cronjob + default date should be date_due, not issuedate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 Bug ID: 9499 Summary: --itemscontent= option is undocumented in advanced-notice.pl cronjob + default date should be date_due, not issuedate Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: liz@catalyst.net.nz advance_notices.pl has an undocumented feature to allow --itemscontent=<fields> select what fields are put in itemscontent in notices. Additionally, these notices ship by default with the dateissued, instead of the date_due, which makes little sense to borrowers. I propose we change the default date on advanced_notices to date_due (remember, you'll retain the option to set it to the dateissued if you want to), update the crontab.example to reflect the change as well, and improve the POD to reflect that the option is available for advanced/due notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 --- Comment #1 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14877&action=edit Bug 9499 - --itemscontent= option is undocumented in advanced-notice.pl cronjob + default date should be date_due, not issuedate To Test: Set up a borrower to receive due and/or predue notices. Define your predue and/or due notice to use <<items.content>> Give your borrower an issue that will trigger a notice to be sent (Example: Henry Acevedo has checked out a book that will be coming due tomorrow, he wants to receive predue notices 1 day in advance) On the command line, run (your paths may vary, these are mine): sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl -c -n Note that the date listed is the due date, not the issue date. Then run: sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl -c -n --itemscontent=issuedate,title,author,barcode Note that the date listed is the issue date, not the date due. Also run sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl --help Should show the help. sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl --man Should show the man page version of the help. sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl Should show the help. This script requires confirmation before running (-c or nothing is done). Note that the documentation refers to the --itemscontent= option and now allows --man as well as --help. Also it is a proper POD. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |liz@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14877|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15078&action=edit [SIGNED-OFF] Bug 9499 - --itemscontent= option is undocumented in advanced-notice.pl cronjob + default date should be date_due, not issuedate To Test: Set up a borrower to receive due and/or predue notices. Define your predue and/or due notice to use <<items.content>> Give your borrower an issue that will trigger a notice to be sent (Example: Henry Acevedo has checked out a book that will be coming due tomorrow, he wants to receive predue notices 1 day in advance) On the command line, run (your paths may vary, these are mine): sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl -c -n Note that the date listed is the due date, not the issue date. Then run: sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl -c -n --itemscontent=issuedate,title,author,barcode Note that the date listed is the issue date, not the date due. Also run sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl --help Should show the help. sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl --man Should show the man page version of the help. sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl Should show the help. This script requires confirmation before running (-c or nothing is done). Note that the documentation refers to the --itemscontent= option and now allows --man as well as --help. Also it is a proper POD. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works as advertised according to the fine test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch updates the pod for the advance_notices.pl script using the Pod::Usage module. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15078|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15105&action=edit Bug 9499 - --itemscontent= option is undocumented in advanced-notice.pl cronjob + default date should be date_due, not issuedate To Test: Set up a borrower to receive due and/or predue notices. Define your predue and/or due notice to use <<items.content>> Give your borrower an issue that will trigger a notice to be sent (Example: Henry Acevedo has checked out a book that will be coming due tomorrow, he wants to receive predue notices 1 day in advance) On the command line, run (your paths may vary, these are mine): sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl -c -n Note that the date listed is the due date, not the issue date. Then run: sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl -c -n --itemscontent=issuedate,title,author,barcode Note that the date listed is the issue date, not the date due. Also run sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl --help Should show the help. sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl --man Should show the man page version of the help. sudo env KOHA_CONF=/etc/koha/sites/devlibrary/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl advance_notices.pl Should show the help. This script requires confirmation before running (-c or nothing is done). Note that the documentation refers to the --itemscontent= option and now allows --man as well as --help. Also it is a proper POD. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works as advertised according to the fine test plan. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The one thing I'm not sure about in this patch is the change from issuedate to date_due. I agree it makes more sense, but before we change the default behavior I'd like to know if anyone has any idea why the default was issuedate before. Anyone? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #5)
The one thing I'm not sure about in this patch is the change from issuedate to date_due. I agree it makes more sense, but before we change the default behavior I'd like to know if anyone has any idea why the default was issuedate before. Anyone?
I don't know why. Regarding to the git log, it is an old commit. But obviously, date_due is more relevant here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 --- Comment #7 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- When I was writing this patch, I went back and looked at when this was added - it has been this way since the beginning. No one has been much bothered to change it, apparently, or if they have, they used the heretofore undocumented --itemscontent flag. My suspicion is that libraries don't look at the actual output of these notices very often - they get sent out and they never see what information is contained in items.content. That, or they see it but don't grok that it's issuedate instead of date-due. It's clear that if there were complaints, they were previously unvoiced, at least to bugzilla. However, the impetus for this patch came from a library who noticed the discrepancy - I can only assume others have noticed too. That said, date_due makes a whole lot more sense for the purpose of the notice - we were sending out a notice telling patrons that an item was due, but that didn't tell patrons when the item was due, only when they checked it out. That doesn't seem helpful. As noted, the behaviour can be reverted to "the old way" by using the --itemscontent flag on the cronjob and passing the issuedate instead of the due_date. Also, if you had previously specified date_due using the items.content flag on the cron job, that behaviour won't change with this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be 3.10.3 and 3.8.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9499 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14624 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org