[Bug 34226] New: Format dates from DT filters before querying the REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Bug ID: 34226 Summary: Format dates from DT filters before querying the REST API Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 22440 Blocks: 33568 If we have filters on top of column on a table that is using the DT REST API wrapper, we cannot filter on date using formatted dates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] Improve ILL page performance by moving to server side filtering https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153180&action=edit Bug 34226: DT wrapper - pre-processed date term when filtering If we have filters on top of column on a table that is using the DT REST API wrapper, we cannot filter on date using formatted dates. This was done for "date of birth" for bug 32505. Here we want to provide a generic approach. Note that we cannot use what has been done on bug 22440 in some cases (when we don't write the thead DOM directly but rely on DataTables constructor, for instance bug 33568). The data- attributes are not passed by DT. Test plan: On top of 33568, filter date columns using the full version of the formatted date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29422 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153180|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153830&action=edit Bug 34226: DT wrapper - pre-processed date term when filtering If we have filters on top of column on a table that is using the DT REST API wrapper, we cannot filter on date using formatted dates. This was done for "date of birth" for bug 32505. Here we want to provide a generic approach. Note that we cannot use what has been done on bug 22440 in some cases (when we don't write the thead DOM directly but rely on DataTables constructor, for instance bug 33568). The data- attributes are not passed by DT. Test plan: On top of 33568, filter date columns using the full version of the formatted date Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153831&action=edit Bug 34226: WIP Using 'type' at the datatable config level What about using 'type' definitions at the datatables settings level and binding that to a flatpickr instance? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I struggled a bit to put this in context with bug 33568 so I was testing it using the patrons search table (yes, I know.. it's already one of the more complex ones) I've added a patch on top that takes us towards a more generic way of displaying the standard flatpickr in the search headers.. does this go towards achieving what you hope or am I completely misunderstanding the work here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Thanks Martin, that's definitely the way to go. I thought I tried it and it didn't work, but apparently I was wrong. There is only thing however that would not work directly: the apply_flatpickr. It is in calendar.inc and you have to include it from the tt you are including datatables.js I've tried with 33568 and it does not work (at least easily) because of the way includes and js files are embedded. I would move the flatpickr thing to another bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is another thing with flatpickr: you cannot longer search for a year. If you want to search all patrons born in 1958, flatpickr will blank the input if no date has been selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153835&action=edit Bug 34226: Remove apply_flatpickr It needs more work. The include calendar.inc should not be done in patron-search.inc, and the order of the include (inc+js) is wrong at some point (need more investigation) Also you cannot search for a specific year, you need to enter a valid date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I've updated and adjusted the remote branch of bug 33568 with your suggestion and it is working great. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent, thanks for the feedback Jonathan, I'm glad I could help here. Yes, more than happy to migrate the flatpickr piece into it's own bug, that's certainly where the WIP was headed.. I agree, the order of inserting the JS is a bit funky and I'd like to somehow improve that but got a bit stuck there in the quick look I had. As for year only, I also spotted that and wasn't yet sure how to overcome it. I'll open another bug for the flatpickr side.. it's a lovely addition if we can get it working for the cases we need. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34352 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34352 [Bug 34352] It would be great to have a generic flatpickr based input for datatables column filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32559 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Oh.. isn't this also an almost duplicate of bug 32559 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 32559 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Yes, definitely a duplicate! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Will be submitting the squash of both bugs first thing in the morning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153830|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153862&action=edit Bug 34226: DT wrapper - pre-processed date term when filtering If we have filters on top of column on a table that is using the DT REST API wrapper, we cannot filter on date using formatted dates. This was done for "date of birth" for bug 32505. Here we want to provide a generic approach. Note that we cannot use what has been done on bug 22440 in some cases (when we don't write the thead DOM directly but rely on DataTables constructor, for instance bug 33568). The data- attributes are not passed by DT. Test plan: On top of 33568, filter date columns using the full version of the formatted date Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153863&action=edit Bug 34226: Use 'type' at the datatable config level Lets use 'type' definitions at the datatables settings level instead Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153864&action=edit Bug 34226: Add tests Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153835|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153831|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bugs merged, tests stolen, WIP commit and follow-up squashed and all submitted here.. signoffs migrated and QA scripts all run for good measure again. All is working well from my perspective, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Applied these patches on the remote branch of bug 33568 and all seems to work perfectly. Thanks, Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not backported to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org