http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25392|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25533&action=edit Bug 11562: sysprefs.sql is not correctly sorted. The QA tools does not manage to catch error sorting on the sysprefs.sql file if it is already bad sorted. This patch tidies up the sysprefs file. TEST PLAN --------- 0) Back up your system preferences table. 1) check out master 2) Use your koha database, and then: DELETE FROM systempreferences; SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql 3) suspend your mysql client and type something similar to: mysql -u root -p -e 'USE kohadata;SELECT * from systempreferences ORDER BY Variable;' > ~/master_sysprefs 4) apply the patch 5) foreground your mysql client, and then: DELETE FROM systempreferences; SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql 6) suspend your mysql client and type something similar to: mysql -u root -p -e 'USE kohadata;SELECT * from systempreferences ORDER BY Variable;' > ~/11562_sysprefs 7) foreground your mysql client and quit 8) Take a diff, they should be identical diff ~/master_sysprefs ~/11562_sysprefs NOTE: You can't use your own system preferences values, because upgrades and changed values would require a lot of time to compare the results. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, although as you can probably see from the comment I made in the commit message, I would suggest that it is a good idea to not lose perspective on the difference between a minor convention meant to reduce the chance of merge conflicts as opposed to an actual error. Thanks, Jonathan. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11562 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.