[Bug 38684] New: Improve translatability in cat-toolbar.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 Bug ID: 38684 Summary: Improve translatability in cat-toolbar.inc Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com There are two strings that could use `I18N.tnx` to improve translatability. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |tomascohen@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 175395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175395&action=edit Bug 38684: Improve translatability in cat-toolbar.inc This patch converts strings using * *subscription(s)* * *item(s)* into different strings for the singular and plural forms. This helps translating and is also more accurate for the end user. To test: 1. Have a record with 2 items and 2 subscriptions 2. hover on the _Edit > Delete record_ dropdown item => FAIL: Mixed form string about items 3. Delete one item at a time, repeating 2 => FAIL: Mixed form string at each step 4. Once items are deleted, repeat 2 => FAIL: Mixed form string about subscriptions 5. Delete one subscription at a time, repeating 2 => FAIL: Mixed form string at each step 6. Apply this patch 7. Repeat 1-5 => SUCCESS: Different message in singular and plural forms => SUCCESS: The message is correct 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175395|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175464&action=edit Bug 38684: Improve translatability in cat-toolbar.inc This patch converts strings using * *subscription(s)* * *item(s)* into different strings for the singular and plural forms. This helps translating and is also more accurate for the end user. To test: 1. Have a record with 2 items and 2 subscriptions 2. hover on the _Edit > Delete record_ dropdown item => FAIL: Mixed form string about items 3. Delete one item at a time, repeating 2 => FAIL: Mixed form string at each step 4. Once items are deleted, repeat 2 => FAIL: Mixed form string about subscriptions 5. Delete one subscription at a time, repeating 2 => FAIL: Mixed form string at each step 6. Apply this patch 7. Repeat 1-5 => SUCCESS: Different message in singular and plural forms => SUCCESS: The message is correct 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA by RM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- $ koha-translate --update fr-CA --dev kohadev Can't use an undefined value as a HASH reference at /kohadevbox/koha/misc/translator/tmpl_process3.pl line 134. git blaming this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176048&action=edit Bug 38684: FIX2 Fix koha-translate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- 2 possible fixes. I think the second one is better. More work/duplication for translators but at least it's clear and there is no weirdness with punctuation. Note that it would be good to include something about testing the translation workflow when we "improve the translatability" ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176049&action=edit Bug 38684: FIX1 Fix koha-translate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #7)
2 possible fixes.
I think the second one is better.
Which is the first one submitted :D "FIX2" is better! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I need to check the diff of these with git... currently not spotting the difference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- OK; I picked FIX2, but made the commit message a little nicer. --color-words=. is helpful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 --- Comment #12 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Oops. Thanks Jonathan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 --- Comment #13 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #7)
I think the second one is better. More work/duplication for translators but at least it's clear and there is no weirdness with punctuation.
Agreed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement improves release notes| |the translatability of the | |tool tips for 'Edit > | |Delete record' on the | |record details page in the | |staff interface. It makes | |it easier to translate the | |singular and plural forms | |of items and subscriptions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sergeinik@tut.by --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 39443 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38684 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #16 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org