[Bug 30082] New: Bibliographic details tab missing when user can't add local cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Bug ID: 30082 Summary: Bibliographic details tab missing when user can't add local cover image Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Created attachment 130506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130506&action=edit Screenshot showing the problem There is an error in the logic controlling whether the "Images" tab appears on the bibliographic detail page in the staff interface. If the LocalCoverImages preference is enabled but the logged-in user doesn't have CAN_user_tools_upload_local_cover_images permission the "No images..." text appears outside of the tabs. This is because the logic for displaying the message differs from the logic for displaying the corresponding tab link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032 [Bug 22032] Improve local cover image tab on detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130510&action=edit Bug 30082: Bibliographic details tab missing when user can't add local cover image This patch corrects the template logic which determines whether the "Images" tab should be displayed on the bibliographic detail page. The "Images" tab should display whenever local cover images are enabled, not just if the user has permission to manage cover images. To test, apply the patch and go to Administration -> System preferences. - Enable the LocalCoverImages system preference. - Locate and view the detail page for a bibliographic record in the catalog which doesn't have a local cover image attached. - If you are logged in as a user with upload_local_cover_images permission you should see an "Images" tab with the message "No images have been uploaded for this bibliographic record yet" and an upload button. - If you are logged in as a user without upload_local_cover_images permission you should see an "Images" tab with just the "No images..." message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130510|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 130530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130530&action=edit Bug 30082: Bibliographic details tab missing when user can't add local cover image This patch corrects the template logic which determines whether the "Images" tab should be displayed on the bibliographic detail page. The "Images" tab should display whenever local cover images are enabled, not just if the user has permission to manage cover images. To test, apply the patch and go to Administration -> System preferences. - Enable the LocalCoverImages system preference. - Locate and view the detail page for a bibliographic record in the catalog which doesn't have a local cover image attached. - If you are logged in as a user with upload_local_cover_images permission you should see an "Images" tab with the message "No images have been uploaded for this bibliographic record yet" and an upload button. - If you are logged in as a user without upload_local_cover_images permission you should see an "Images" tab with just the "No images..." message. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130530|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130537&action=edit Bug 30082: Bibliographic details tab missing when user can't add local cover image This patch corrects the template logic which determines whether the "Images" tab should be displayed on the bibliographic detail page. The "Images" tab should display whenever local cover images are enabled, not just if the user has permission to manage cover images. To test, apply the patch and go to Administration -> System preferences. - Enable the LocalCoverImages system preference. - Locate and view the detail page for a bibliographic record in the catalog which doesn't have a local cover image attached. - If you are logged in as a user with upload_local_cover_images permission you should see an "Images" tab with the message "No images have been uploaded for this bibliographic record yet" and an upload button. - If you are logged in as a user without upload_local_cover_images permission you should see an "Images" tab with just the "No images..." message. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30082 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org