[Bug 17336] New: api_secret_passphrase missing in packages setup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Bug ID: 17336 Summary: api_secret_passphrase missing in packages setup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 13799 introduced the api_secret_passphrase on source installs, but missed to do so on packages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 55778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55778&action=edit Bug 17336: Add api_secret_passphrase entry in packages setup Bug 13799 introduced the api_secret_passphrase on source installs, but missed to do so on packages. This patch introduces the entry on the template koha-conf-site.xml.in file, and patches koha-create so it generates a randomized string (64 chars) to put in it. To test: - Apply the patch - Grab the new template file: $ sudo cp kohaclone/debian/templates/koha-conf-site.xml.in \ /etc/koha - Create a new instance: $ kohaclone/debian/scripts/koha-create --create-db blah => SUCCESS: The script runs fine, /etc/koha/sites/blah/koha-conf.xml contains the api_secret_passphrase entry. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com | |, kyle.m.hall@gmail.com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Bug 17336 depends on bug 13799, which changed state. Bug 13799 Summary: Add base for building RESTful API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Applying: Bug 17336: Add api_secret_passphrase entry in packages setup fatal: sha1 information is lacking or useless (debian/templates/koha-conf-site.xml.in). error: could not build fake ancestor Patch failed at 0001 Bug 17336: Add api_secret_passphrase entry in packages setup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17332 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17332 [Bug 17332] Memcached configuration missing in koha-conf* files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Sorry, forgot I wrote it on top of 17332 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55778|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 55818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55818&action=edit Bug 17336: Add api_secret_passphrase entry in packages setup Bug 13799 introduced the api_secret_passphrase on source installs, but missed to do so on packages. This patch introduces the entry on the template koha-conf-site.xml.in file, and patches koha-create so it generates a randomized string (64 chars) to put in it. To test: - Apply the patch - Grab the new template file: $ sudo cp kohaclone/debian/templates/koha-conf-site.xml.in \ /etc/koha - Create a new instance: $ kohaclone/debian/scripts/koha-create --create-db blah => SUCCESS: The script runs fine, /etc/koha/sites/blah/koha-conf.xml contains the api_secret_passphrase entry. - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55818|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55830&action=edit Bug 17336: Add api_secret_passphrase entry in packages setup Bug 13799 introduced the api_secret_passphrase on source installs, but missed to do so on packages. This patch introduces the entry on the template koha-conf-site.xml.in file, and patches koha-create so it generates a randomized string (64 chars) to put in it. To test: - Apply the patch - Grab the new template file: $ sudo cp kohaclone/debian/templates/koha-conf-site.xml.in \ /etc/koha - Create a new instance: $ kohaclone/debian/scripts/koha-create --create-db blah => SUCCESS: The script runs fine, /etc/koha/sites/blah/koha-conf.xml contains the api_secret_passphrase entry. - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17336 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Oldversions |--- Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28911 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org