[Bug 18043] New: Updating buttons for z39.50 cataloguing search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 Bug ID: 18043 Summary: Updating buttons for z39.50 cataloguing search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Buttons that need to use bootstrap 3/font awesome icons: - Search - MARC (fa) - Card (fa) - Import (fa) - Previous page/Next page - Go - Try another search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 59837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59837&action=edit Bug 18043: Updating buttons for z39.50 cataloguing search 1) Go to Cataloguing -> New from Z39.50 2) Do a search, noticing the ugly buttons from Comment 1 3) Apply patch and go back to a new search 4) Do a search again, noticing the new, nicer buttons 5) Confirm they still work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |aleishaamohia@hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17873 CC| |josef.moravec@gmail.com, | |oleonard@myacpl.org --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- I am for fa icons on buttons Search, Go and Try another search, ccing Owen to get his opinion... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17873 [Bug 17873] Make all buttons Bootstrap styled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59837|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 59960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59960&action=edit Bug 18043: Updating buttons for z39.50 cataloguing search 1) Go to Cataloguing -> New from Z39.50 2) Do a search, noticing the ugly buttons from Comment 1 3) Apply patch and go back to a new search 4) Do a search again, noticing the new, nicer buttons 5) Confirm they still work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |veron@veron.ch --- Comment #4 from Marc Véron <veron@veron.ch> --- Buttons display as expected, but "Go to page" is broken. Reason: Button "Go" definition misses: value="Go" If I add it (line 212), "Go to page" works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59960|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 60361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60361&action=edit Bug 18043: Updating buttons for z39.50 cataloguing search 1) Go to Cataloguing -> New from Z39.50 2) Do a search, noticing the ugly buttons from Comment 1 3) Apply patch and go back to a new search 4) Do a search again, noticing the new, nicer buttons 5) Confirm they still work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Marc Véron from comment #4)
Buttons display as expected, but "Go to page" is broken. Reason: Button "Go" definition misses: value="Go" If I add it (line 212), "Go to page" works.
Fixed in latest patch. Ready for signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Marc Véron <veron@veron.ch> --- "Go" button works now, but not next / previous page buttons. Oh, they miss 'value' as well (value="Next page" / value="Previous page") -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|oleonard@myacpl.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|Failed QA |RESOLVED --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this has also been resolved with the staff interface redesign and some other changes since this was filed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org