[Bug 16785] New: Autocomplete broken on overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Bug ID: 16785 Summary: Autocomplete broken on overdues report Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/overdue.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, koha-bugs@lists.koha-community.org, kyle.m.hall@gmail.com If you have a patron attribute defined which is searchable and linked to an authorized value, that attribute will show up in the overdue report filter form as an autocomplete field. The autocomplete is broken for cases where more than one result is returned by the search. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This appears to still be broken - even more than when reported. It appears now that the pull down with options never loads. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- eferenceError: create_auto_completion_responder is not defined[Learn More] overdue.pl:486:1 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org Status|ASSIGNED |NEW --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #2)
eferenceError: create_auto_completion_responder is not defined[Learn More] overdue.pl:486:1
This aspect of it was caused by Bug 19700, but even after reverting that change the original problem still exists. I'm inclined to say this should not be an autocomplete field at all--it should be a regular dropdown. But the script is too much of a tangle for me to figure that out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd agree, autocomplete doesn't match how we treat these fields elsewhere, so having a drop down would work better. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120972&action=edit Bug 16785: Remove Autocomplete from overdues report filter This patch removes code and markup related to an autocomplete input field in the overdues report filter. The autocomplete was intended to enable easy entry of patron attributes, but it's simpler to use a Select2-styled <select> The patch removes circ/ypattrodue-attr-search-authvalue.pl, which was only used on this page and is now obsolete. To test, apply the patch and create at least one patron attribute type which is linked to an authorized value: - Administration -> Authorized values -> New category - Create a new category to test with - Add multiple authorized values under this category - Administration -> Patron attribute types -> New patron attribute type. - Create an attribute which is linked to the authorized value category you created AND which is marked "Searchable." - Go to Circulation -> Overdues. - In the sidebar filter you should see your patron attribute as an option, styled as a Select2 dropdown. - Clicking the dropdown should trigger a list of the authorized values you created above. - Test that the search field at the top of the list works correctly to filter the results. - Test that any repeatable attribute field can be cloned by clicking the "Add" link, and that cloned fields can be removed using the "Delete" links. - Test that cloned fields remain in place after submitting the fitler form, and that any selected entry in a Select2 widget is preselected. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 28331 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22956 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22956 [Bug 22956] Omnibus: Remove type attribute from script tags -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120972|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 121019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121019&action=edit Bug 16785: Remove Autocomplete from overdues report filter This patch removes code and markup related to an autocomplete input field in the overdues report filter. The autocomplete was intended to enable easy entry of patron attributes, but it's simpler to use a Select2-styled <select> The patch removes circ/ypattrodue-attr-search-authvalue.pl, which was only used on this page and is now obsolete. To test, apply the patch and create at least one patron attribute type which is linked to an authorized value: - Administration -> Authorized values -> New category - Create a new category to test with - Add multiple authorized values under this category - Administration -> Patron attribute types -> New patron attribute type. - Create an attribute which is linked to the authorized value category you created AND which is marked "Searchable." - Go to Circulation -> Overdues. - In the sidebar filter you should see your patron attribute as an option, styled as a Select2 dropdown. - Clicking the dropdown should trigger a list of the authorized values you created above. - Test that the search field at the top of the list works correctly to filter the results. - Test that any repeatable attribute field can be cloned by clicking the "Add" link, and that cloned fields can be removed using the "Delete" links. - Test that cloned fields remain in place after submitting the fitler form, and that any selected entry in a Select2 widget is preselected. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121019|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121043&action=edit Bug 16785: Remove Autocomplete from overdues report filter This patch removes code and markup related to an autocomplete input field in the overdues report filter. The autocomplete was intended to enable easy entry of patron attributes, but it's simpler to use a Select2-styled <select> The patch removes circ/ypattrodue-attr-search-authvalue.pl, which was only used on this page and is now obsolete. To test, apply the patch and create at least one patron attribute type which is linked to an authorized value: - Administration -> Authorized values -> New category - Create a new category to test with - Add multiple authorized values under this category - Administration -> Patron attribute types -> New patron attribute type. - Create an attribute which is linked to the authorized value category you created AND which is marked "Searchable." - Go to Circulation -> Overdues. - In the sidebar filter you should see your patron attribute as an option, styled as a Select2 dropdown. - Clicking the dropdown should trigger a list of the authorized values you created above. - Test that the search field at the top of the list works correctly to filter the results. - Test that any repeatable attribute field can be cloned by clicking the "Add" link, and that cloned fields can be removed using the "Delete" links. - Test that cloned fields remain in place after submitting the fitler form, and that any selected entry in a Select2 widget is preselected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice one.. this works great now. All works as expected, no QA script failures reported. Passing QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.06 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Doesn't apply cleanly to 20.05, please rebase if needed. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 121393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121393&action=edit Bug 16785: [20.05] Remove Autocomplete from overdues report filter This patch removes code and markup related to an autocomplete input field in the overdues report filter. The autocomplete was intended to enable easy entry of patron attributes, but it's simpler to use a Select2-styled <select> The patch removes circ/ypattrodue-attr-search-authvalue.pl, which was only used on this page and is now obsolete. To test, apply the patch and create at least one patron attribute type which is linked to an authorized value: - Administration -> Authorized values -> New category - Create a new category to test with - Add multiple authorized values under this category - Administration -> Patron attribute types -> New patron attribute type. - Create an attribute which is linked to the authorized value category you created AND which is marked "Searchable." - Go to Circulation -> Overdues. - In the sidebar filter you should see your patron attribute as an option, styled as a Select2 dropdown. - Clicking the dropdown should trigger a list of the authorized values you created above. - Test that the search field at the top of the list works correctly to filter the results. - Test that any repeatable attribute field can be cloned by clicking the "Add" link, and that cloned fields can be removed using the "Delete" links. - Test that cloned fields remain in place after submitting the fitler form, and that any selected entry in a Select2 widget is preselected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org