[Bug 7654] New: Add location an callnumber at opac subscription view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Priority: P5 - low Change sponsored?: --- Bug ID: 7654 Assignee: koha@univ-lyon3.fr Summary: Add location an callnumber at opac subscription view QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: koha@univ-lyon3.fr Hardware: All Status: NEW Version: rel_3_6 Component: OPAC Product: Koha Created attachment 8032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8032&action=edit Add location an callnumber at opac subscription view This adds the location and the callnumber after the branch/library name on each subscription header of a subscription tab, in a serial detailed record at the OPAC. Tied with bug 7653 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #1 from delaye <stephane.delaye@biblibre.com> --- l'application du patch dans une sandbox a echoué Applying: Add location and callnumber at OPAC subscription view Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Add location and callnumber at OPAC subscription view -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8032|0 |1 is obsolete| | --- Comment #2 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 8200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8200&action=edit Add location and callnumber to each subscription in opac subscription tab sorry, the previous patch was uncluding a modification of another local patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 8306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8306&action=edit Commas showing when no data There are some stray commas showing up in this patch if you don't have data in all of the fields. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nengard@gmail.com --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- When it comes to Item type it's showing the item type Code and not the description. For this and the previous comment I'm marking failed QA. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- No new patch attached for signoff, I assume the status change was a mistake, changing back. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Could you please attach your updated patch to this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8200|0 |1 is obsolete| | --- Comment #7 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 14681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14681&action=edit Bug 7654: Add location and callnumber at opac subscription view I corrected the comma's problem. As for the itemtype one, I could see the description in the itemtype column, holding tab. Maybe this problem has been corrected by another patch. However, I could see a new part of code that is seamingly made to display the callnumber but I don't understand under which conditions : <span style="display:none;"> [% IF ( subscription.callnumber ) %]<p>Callnumber: [% subscription.callnumber %]</p>[% END %]</span> I did a new patch nevertheless, but I suppose it 's necessary to harmonize the two callnumber displaying devices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Version|3.6 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Pascale Nalon <pascale.nalon@ensmp.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |pascale.nalon@ensmp.fr --- Comment #8 from Pascale Nalon <pascale.nalon@ensmp.fr> --- Patch applies -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com QA Contact|koha.sekjal@gmail.com |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * small patch, passes koha-qa.pl * i've added a tiny follow-up to remove 2 trailing spaces Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14681|0 |1 is obsolete| | --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16677&action=edit [PASSED QA] Bug 7654:Add location and callnumber at opac subscription view Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16678&action=edit [PASSED QA] Bug 7654 follow-up: reindent Before this patch, there was a trailing space between branch, location and callnumber After this patch it's written branch, location, callnumber as expected Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #8)
Patch applies
Pascale, Did you test this patch and sign off on it? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #13 from Pascale Nalon <pascale.nalon@ensmp.fr> --- Bonjour, Yes, I signed off this patch during the hackfest in Marseille, last week. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #14 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Hello, I don't understand why this bug is "in discussion" after being signed-off et passed QA. I don't see in the comments an explanation about this status. Thanks, Sonia -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off CC| |katrin.fischer@bsz-bw.de --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we can fix the sign-off line in QA - switching back to signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|paul.poulain@biblibre.com |jonathan.druart@biblibre.co | |m --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Why do you add a br tag in the h3 title? The callnumber is hidden 2 line bellow, I think you can remove it. Maybe it is better to keep the existing one (callnumber). If all values are there, the h3 title will be too long, don't you think? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #17 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I suppose this br was meant to separate more clearly the "This is a serial" block from the localisations (if I had put it at the right place, after the h2 element). Ok for removing the hidden callnumber (didn't really understood what it does here) As for the length of h3, for us it's ok, may be some will find it too long. I joined a capture of an example in Lyon3. May be the closed mention ('This subscription is closed.') ,if present, would have to be move beneath the h3. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org