https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 162524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162524&action=edit Bug 36188: Sort lists by items.dateaccessioned in the staff client WIP Sponsored-By: The Treasury, New Zealand -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Patches written, test plans to come. Not ready for testing yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162524|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 162549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162549&action=edit Bug 36188: Sort lists by items.dateaccessioned in the OPAC WIP Sponsored-By: The Treasury, New Zealand -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162548|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 162555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162555&action=edit Bug 36188: Sort lists by items.dateaccessioned in the OPAC When a list is sorted by dateaccessioned it should be ordered descending by default. This is to ensure the newest items are displayed first. Test plan: 1. Apply patches and restart services 2. In the Staff client, go to the Lists module and create a new list 3. Set the 'Sort this list by' dropdown = 'Date accessioned' 4. Add several barcodes to the list belonging to items with a range of different items.dateaccessioned dates 5. In the staff client observe the list records are ordered by the 'Date accessioned' in descending order - i.e. titles with newest dateaccessioned are displayed first 6. In a new browser window navigate to the list in the Koha OPAC 7. Confirm the list titles in the OPAC are ordered in the same order as the staff client 8. In the OPAC click on the 'Sort' button and select 'Date accession (oldest to newest) 9. Confirm the OPAC list order reverses 10. In the OPAC choose other values from the 'Sort' button and confirm the list is re-sorted correctly Sponsored-By: The Treasury, New Zealand -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Is there a difference in the way sort is calculated between the staff interface and the OPAC? I'm seeing some differences with my own testing data. I'm wondering if it has to do with how titles with the same dateaccessioned are handled. I'm a little bit concerned about using dateaccessioned for sorting, since ordering search results by date uses other data. I imagine it might also be confusing to users who see a title at the top of the list which isn't new per se, it just has a new copy. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 162606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162606&action=edit List sort in the staff interface Note that I edited one item in each record to have the same dateaccessioned. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Owen Leonard from comment #10)

(In reply to Owen Leonard from comment #9)

...

I'm a little bit concerned about using dateaccessioned for sorting

Ignore me, I wasn't thinking about the fact that there is already a "Date added" sorting option.

I wonder if there is a more user-friendly way to say "Date accessioned?" Some way to express that the order is by newest item?

Hi Owen, Thanks for your feedback and taking a look! Looking at your screenshots now. Do you think 'Date acquired' might be a more helpful wording? Happy to change the wording. Alex -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com --- Comment #15 from Esther Melander <esther.melander@bywatersolutions.com> --- I tested this and it appears to work when selecting the date accessioned. However, I couldn't sort the list at all when clicking on the sort button for the other columns. Even though I selected the sort order by date accessioned, I would expect to retain the ability to continue to sort the list in different way when viewing. For example, maybe I want the date accessioned to reverse the sort, or maybe I need to sort by call number next. Clicking on the sort icons in the column header does nothing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162555|0 |1 is obsolete| | --- Comment #17 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 162931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162931&action=edit Bug 36188: Sort lists by items.dateaccessioned in the OPAC When a list is sorted by dateaccessioned it should be ordered descending by default. This is to ensure the newest items are displayed first. Test plan: 1. Apply patches and restart services 2. In the Staff client, go to the Lists module and create a new list 3. Set the 'Sort this list by' dropdown = 'Date accessioned' 4. Add several barcodes to the list belonging to items with a range of different items.dateaccessioned dates 5. In the staff client observe the list records are ordered by the 'Date accessioned' in descending order - i.e. titles with newest dateaccessioned are displayed first 6. In a new browser window navigate to the list in the Koha OPAC 7. Confirm the list titles in the OPAC are ordered in the same order as the staff client 8. In the OPAC click on the 'Sort' button and select 'Date accession (oldest to newest) 9. Confirm the OPAC list order reverses 10. In the OPAC choose other values from the 'Sort' button and confirm the list is re-sorted correctly Sponsored-By: The Treasury, New Zealand Signed-off-by: esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Esther Melander from comment #16)

Testing other tables in Koha, it is possible to click on the sort arrows and have the column sort. In lists, it looks like you have to click on the column name. This is inconsistent behavior, but is perhaps a separate bug.

Lists are one place in Koha that are not yet "DataTable'ed". There is an open bug regarding this: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 --- Comment #20 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 163100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163100&action=edit Bug 36188: Sort lists by Date acquired (items.dateaccessioned) in the staff client When a list is sorted by date acquired it should be ordered descending by default. This is to ensure the newest items are displayed first. Test plan: 1. Apply patches and restart services 2. Go to the Lists module and create a new list 3. Set the 'Sort this list by' dropdown = 'Date acquired' 4. Add several barcodes to the list belonging to items with a range of different items.dateaccessioned dates (952$d subfields) 5. Observe the list records are ordered by the 'Date acquired' column: - Records with the newest date acquired values displayed first. - The date acquired value for each title item record is listed in this column. 6. Switch to order date acquired ascending by clicking on the 'Date acquired' column label - records with the oldest date acquired should be displayed first. 7. Edit the list. Change the 'Sort this list by' dropdown to 'Title' 8. Notice the list records are ordered by the 'Title' column in an ascending order - A-Z alphabetically. Sponsored-By: The Treasury, New Zealand -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162931|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 --- Comment #23 from Esther Melander <esther.melander@bywatersolutions.com> --- The change to Date acquired looks fine. Setting the sort to Date acquired in the list edit screen does seem to sort correctly. I had one bibliographic record with two items with different dates. The list sorted correctly even though the one item was acquired earlier than the other. For example, the top bibliographic record had items with dates acquired that looked like this: 09/04/2014 09/10/2020 The second bibliographic record had an item with this date: 03/17/2016 This sorting is correct since the bibliographic record with the newest item (09/10/2020) is at the top of the list. But is it confusing if the dates themselves are still out of order? Bibliographic records with multiple copies acquired at different times add to the appearance of an incorrect sort. Is there a way to deal with multiple copies acquired at different times. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Baptiste <baptiste.bayche@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163101|0 |1 is obsolete| | --- Comment #24 from Baptiste <baptiste.bayche@inlibro.com> --- Created attachment 166472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166472&action=edit Bug 36188: Sort lists by date acquired (items.dateaccessioned) in the OPAC When a list is sorted by date acquired it should be ordered descending by default. This is to ensure the newest items are displayed first. Test plan: 1. Apply patches and restart services 2. In the Staff client, go to the Lists module and create a new list 3. Set the 'Sort this list by' dropdown = 'Date acquired' 4. Add several barcodes to the list belonging to items with a range of different date acquired dates 5. In the staff client observe the list records are ordered by the 'Date acquired' in descending order - i.e. titles with newest date acquired are displayed first 6. In a new browser window navigate to the list in the Koha OPAC 7. Confirm the list titles in the OPAC are ordered in the same order as the staff client 8. In the OPAC click on the 'Sort' button and select 'Date acquired (oldest to newest) 9. Confirm the OPAC list order reverses 10. In the OPAC choose other values from the 'Sort' button and confirm the list is re-sorted correctly Sponsored-By: The Treasury, New Zealand Signed-off-by: baptiste <baptiste.bayche@inlibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Signed Off |Patch doesn't apply --- Comment #26 from Aleisha Amohia <aleisha@catalyst.net.nz> --- kohadev-koha@kohadevbox:koha((b4054dbb157...))$ git bz apply 36188 Bug 36188 - Allow to sort lists by items.dateaccessioned of item records 163100 - Bug 36188: Sort lists by Date acquired (items.dateaccessioned) in the staff client 166472 - Bug 36188: Sort lists by date acquired (items.dateaccessioned) in the OPAC Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36188: Sort lists by Date acquired (items.dateaccessioned) in the staff client Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt M virtualshelves/shelves.pl Falling back to patching base and 3-way merge... Auto-merging virtualshelves/shelves.pl CONFLICT (content): Merge conflict in virtualshelves/shelves.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 36188: Sort lists by Date acquired (items.dateaccessioned) in the staff client hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-36188-Sort-lists-by-Date-acquired-itemsdateacc-450ljhgm.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163100|0 |1 is obsolete| | --- Comment #27 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 172025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172025&action=edit Bug 36188: Sort lists by Date acquired (items.dateaccessioned) in the staff client When a list is sorted by date acquired it should be ordered descending by default. This is to ensure the newest items are displayed first. Test plan: 1. Apply patches and restart services 2. Go to the Lists module and create a new list 3. Set the 'Sort this list by' dropdown = 'Date acquired' 4. Add several barcodes to the list belonging to items with a range of different items.dateaccessioned dates (952$d subfields) 5. Observe the list records are ordered by the 'Date acquired' column: - Records with the newest date acquired values displayed first. - The date acquired value for each title item record is listed in this column. 6. Switch to order date acquired ascending by clicking on the 'Date acquired' column label - records with the oldest date acquired should be displayed first. 7. Edit the list. Change the 'Sort this list by' dropdown to 'Title' 8. Notice the list records are ordered by the 'Title' column in an ascending order - A-Z alphabetically. Sponsored-By: The Treasury, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Olivier Vezina <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172025|0 |1 is obsolete| | --- Comment #29 from Olivier Vezina <ovezina@inlibro.com> --- Created attachment 172050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172050&action=edit Bug 36188: Sort lists by Date acquired (items.dateaccessioned) in the staff client When a list is sorted by date acquired it should be ordered descending by default. This is to ensure the newest items are displayed first. Test plan: 1. Apply patches and restart services 2. Go to the Lists module and create a new list 3. Set the 'Sort this list by' dropdown = 'Date acquired' 4. Add several barcodes to the list belonging to items with a range of different items.dateaccessioned dates (952$d subfields) 5. Observe the list records are ordered by the 'Date acquired' column: - Records with the newest date acquired values displayed first. - The date acquired value for each title item record is listed in this column. 6. Switch to order date acquired ascending by clicking on the 'Date acquired' column label - records with the oldest date acquired should be displayed first. 7. Edit the list. Change the 'Sort this list by' dropdown to 'Title' 8. Notice the list records are ordered by the 'Title' column in an ascending order - A-Z alphabetically. Sponsored-By: The Treasury, New Zealand Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Olivier Vezina <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |ovezina@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172050|0 |1 is obsolete| | --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176735&action=edit Bug 36188: Sort lists by Date acquired (items.dateaccessioned) in the staff client When a list is sorted by date acquired it should be ordered descending by default. This is to ensure the newest items are displayed first. Test plan: 1. Apply patches and restart services 2. Go to the Lists module and create a new list 3. Set the 'Sort this list by' dropdown = 'Date acquired' 4. Add several barcodes to the list belonging to items with a range of different items.dateaccessioned dates (952$d subfields) 5. Observe the list records are ordered by the 'Date acquired' column: - Records with the newest date acquired values displayed first. - The date acquired value for each title item record is listed in this column. 6. Switch to order date acquired ascending by clicking on the 'Date acquired' column label - records with the oldest date acquired should be displayed first. 7. Edit the list. Change the 'Sort this list by' dropdown to 'Title' 8. Notice the list records are ordered by the 'Title' column in an ascending order - A-Z alphabetically. Sponsored-By: The Treasury, New Zealand Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176735|0 |1 is obsolete| | Attachment #176736|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176737&action=edit Bug 36188: Sort lists by Date acquired (items.dateaccessioned) in the staff client When a list is sorted by date acquired it should be ordered descending by default. This is to ensure the newest items are displayed first. Test plan: 1. Apply patches and restart services 2. Go to the Lists module and create a new list 3. Set the 'Sort this list by' dropdown = 'Date acquired' 4. Add several barcodes to the list belonging to items with a range of different items.dateaccessioned dates (952$d subfields) 5. Observe the list records are ordered by the 'Date acquired' column: - Records with the newest date acquired values displayed first. - The date acquired value for each title item record is listed in this column. 6. Switch to order date acquired ascending by clicking on the 'Date acquired' column label - records with the oldest date acquired should be displayed first. 7. Edit the list. Change the 'Sort this list by' dropdown to 'Title' 8. Notice the list records are ordered by the 'Title' column in an ascending order - A-Z alphabetically. Sponsored-By: The Treasury, New Zealand Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 --- Comment #35 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176739&action=edit Bug 36188: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176737|0 |1 is obsolete| | Attachment #176738|0 |1 is obsolete| | Attachment #176739|0 |1 is obsolete| | --- Comment #37 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 186355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186355&action=edit Bug 36188: Sort lists by Date acquired (items.dateaccessioned) in the staff client When a list is sorted by date acquired it should be ordered descending by default. This is to ensure the newest items are displayed first. Test plan: 1. Apply patches and restart services 2. Go to the Lists module and create a new list 3. Set the 'Sort this list by' dropdown = 'Date acquired' 4. Add several barcodes to the list belonging to items with a range of different items.dateaccessioned dates (952$d subfields) 5. Observe the list records are ordered by the 'Date acquired' column: - Records with the newest date acquired values displayed first. - The date acquired value for each title item record is listed in this column. 6. Switch to order date acquired ascending by clicking on the 'Date acquired' column label - records with the oldest date acquired should be displayed first. 7. Edit the list. Change the 'Sort this list by' dropdown to 'Title' 8. Notice the list records are ordered by the 'Title' column in an ascending order - A-Z alphabetically. Sponsored-By: The Treasury, New Zealand Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When a list is sorted by release notes| |date acquired it should be | |ordered descending by | |default. This is to ensure | |the newest items are | |displayed first. Assignee|alexbuckley@catalyst.net.nz |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36188 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.