https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 --- Comment #1 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 61169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61169&action=edit Bug 18282: operationId must be unique operationId has the following documentation: "Unique string used to identify the operation. The id MUST be unique among all operations described in the API." This patch modifies operationIds to be unique accross our API operations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Lari, shouldn't this patch also change the controller class function names? - sub list { + sub list_cities { - sub add { + sub add_city { - sub update { + sub update_city { - sub delete { + sub delete_city { -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 --- Comment #3 from Lari Taskula <lari.taskula@jns.fi> --- (In reply to Tomás Cohen Arazi from comment #2)

Lari, shouldn't this patch also change the controller class function names?

- sub list { + sub list_cities { - sub add { + sub add_city { - sub update { + sub update_city { - sub delete { + sub delete_city {

With Swagger2 plugin yes, but I set this as dependent on Mojolicious::Plugin::OpenAPI, which is using "x-mojo-to" for pointing to the controller class operation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Lari Taskula from comment #4)

(In reply to Lari Taskula from comment #3)

...

(In reply to Tomás Cohen Arazi from comment #2)

...

Lari, shouldn't this patch also change the controller class function names?

- sub list { + sub list_cities { - sub add { + sub add_city { - sub update { + sub update_city { - sub delete { + sub delete_city {

With Swagger2 plugin yes, but I set this as dependent on Mojolicious::Plugin::OpenAPI, which is using "x-mojo-to" for pointing to the controller class operation.

In fact not either with Swagger2. As you can see from patrons controller.

I tend to prefer avoiding black magic as much as possible to avoid unexpected behaviours. That's why I prefer to explicitly put the most similar to the function name. But keep moving and see how bad/good it looks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61169|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 66369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66369&action=edit Bug 18282: operationId must be unique operationId has the following documentation: "Unique string used to identify the operation. The id MUST be unique among all operations described in the API." This patch modifies operationIds to be unique accross our API operations. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lari.taskula@jns.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Web services |REST api -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.