[Bug 37369] New: Item search column filtering can't use descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Bug ID: 37369 Summary: Item search column filtering can't use descriptions Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: anni.rajala@turku.fi QA Contact: testopia@bugs.koha-community.org At the moment, the filtering on item results page requires using the code in the following fields: - Collection - Home library - Current library - Shelving location - Itemtype - item status -fields (not for loan etc) So e.g. "Centerville" in Home library -field doesn't bring back results but code "CPL" does. However, the user might not have a clue what the codes are so instead of codes, it should be possible to use descriptions in the filters. This issue has previously been mentioned in bugs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37249 and https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37238, but I couldn't find a bug that would particularly concern this problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Setting importance of this as "Normal" since it's significantly affecting the usability of item search table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37249 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | Status|NEW |ASSIGNED --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- I think I found the solution to this. When item search result table is build, function columnFilter receives option "columns". It should be "aoColumns" like it was in version 23. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 171960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171960&action=edit Bug 37369: Fix filtering of search result table in item search At the moment, the filtering on item results page requires using the code in the following fields: - Collection - Home library - Current library - Shelving location - Itemtype - item status -fields (not for loan etc) So e.g. "Centerville" in Home library -field doesn't bring back results but code "CPL" does. This happens because "columns" option in search results table isn't working when its used in function columnFilter. However option "aoColumns" works. To test: 1. Navigate to item search and search items. => Note that all filters in search result table are free text fields. 2. Attempt to filter search results by home library with description of some library. => No results are displayed. 3. Now filter results with code of the library. => Results are now displayed. 4. Apply this patch and refresh page. 5. Search items again. => Note that now some of the filters are now using dropdown select fields. 6. Attempt to filter results by home library again. => Results are now displayed correctly. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Olivier Hubert <olivier.hubert@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Olivier Hubert <olivier.hubert@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171960|0 |1 is obsolete| | --- Comment #4 from Olivier Hubert <olivier.hubert@inlibro.com> --- Created attachment 171991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171991&action=edit Bug 37369: Fix filtering of search result table in item search At the moment, the filtering on item results page requires using the code in the following fields: - Collection - Home library - Current library - Shelving location - Itemtype - item status -fields (not for loan etc) So e.g. "Centerville" in Home library -field doesn't bring back results but code "CPL" does. This happens because "columns" option in search results table isn't working when its used in function columnFilter. However option "aoColumns" works. To test: 1. Navigate to item search and search items. => Note that all filters in search result table are free text fields. 2. Attempt to filter search results by home library with description of some library. => No results are displayed. 3. Now filter results with code of the library. => Results are now displayed. 4. Apply this patch and refresh page. 5. Search items again. => Note that now some of the filters are now using dropdown select fields. 6. Attempt to filter results by home library again. => Results are now displayed correctly. Sponsored-by: Koha-Suomi Oy Signed-off-by: Olivier Hubert <olivier.hubert@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- This changes filter behavior from free text to select dropdown but I suspect that is what is intended with "{ 'type': 'select', 'values':..." Passing QA here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171991|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171997&action=edit Bug 37369: Fix filtering of search result table in item search At the moment, the filtering on item results page requires using the code in the following fields: - Collection - Home library - Current library - Shelving location - Itemtype - item status -fields (not for loan etc) So e.g. "Centerville" in Home library -field doesn't bring back results but code "CPL" does. This happens because "columns" option in search results table isn't working when its used in function columnFilter. However option "aoColumns" works. To test: 1. Navigate to item search and search items. => Note that all filters in search result table are free text fields. 2. Attempt to filter search results by home library with description of some library. => No results are displayed. 3. Now filter results with code of the library. => Results are now displayed. 4. Apply this patch and refresh page. 5. Search items again. => Note that now some of the filters are now using dropdown select fields. 6. Attempt to filter results by home library again. => Results are now displayed correctly. Sponsored-by: Koha-Suomi Oy Signed-off-by: Olivier Hubert <olivier.hubert@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Version|24.05 |Main QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com Status|Pushed to oldoldstable |Pushed to oldoldoldstable --- Comment #10 from Jesse Maseto <jesse@bywatersolutions.com> --- This will be pushed to 22.11.x. for 22.11.25 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37369 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz Version(s)|24.11.00,24.05.06,23.11.11 |24.11.00,24.05.06,23.11.11, released in| |22.11.25 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org