[Bug 16836] New: Document unused parameters of SearchAuthorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836 Bug ID: 16836 Summary: Document unused parameters of SearchAuthorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 52951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52951&action=edit Bug 16836: Document unused parameters of SearchAuthorities Two parameters $and_or and $excluding are not used. Test plan: Run t/db_dependent/Search.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- If you query $ git grep 'SearchAuthorities' There are some lines that use the two parameters, maybe exist more: authorities/auth_finder.pl: SearchAuthorities( \@marclist, \@and_or, \@excluding, \@operator, \@value, authorities/authorities-home.pl: #my ( $results, $total ) = SearchAuthorities( authorities/ysearch.pl: my ( $results, $total ) = SearchAuthorities( \@marclist, \@and_or, \@excluding, \@operator, \@value, $startfrom * $resultsperpage, $resultsperpage, $authtypecode, $orderby ); cataloguing/value_builder/unimarc_field_210c.pl:###TODO To rewrite in order to use SearchAuthorities cataloguing/value_builder/unimarc_field_210c.pl: my ($results,$total) = SearchAuthorities( \@tags,\@and_or, cataloguing/value_builder/unimarc_field_225a.pl: my ($results,$total) = SearchAuthorities( \@tags,\@and_or, Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Héctor Eduardo Castro Avalos from comment #2)
If you query $ git grep 'SearchAuthorities'
There are some lines that use the two parameters, maybe exist more:
authorities/auth_finder.pl: SearchAuthorities( \@marclist, \@and_or, \@excluding, \@operator, \@value, authorities/authorities-home.pl: #my ( $results, $total ) = SearchAuthorities( authorities/ysearch.pl: my ( $results, $total ) = SearchAuthorities( \@marclist, \@and_or, \@excluding, \@operator, \@value, $startfrom * $resultsperpage, $resultsperpage, $authtypecode, $orderby ); cataloguing/value_builder/unimarc_field_210c.pl:###TODO To rewrite in order to use SearchAuthorities cataloguing/value_builder/unimarc_field_210c.pl: my ($results,$total) = SearchAuthorities( \@tags,\@and_or, cataloguing/value_builder/unimarc_field_225a.pl: my ($results,$total) = SearchAuthorities( \@tags,\@and_or,
Regards
Hello Hector, That is true. The parameters are passed to the routine, but they actually do nothing. This patch makes that fact more visible without having to change all calls of the routine. Note that this allows someone to adjust the routine to do something useful with these parameters. Marcel -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Time goes by -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org