http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12982 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12982 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This is my first try at modifying a template plugin, so I hope I've done it correctly. Should the addition have a test? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12982 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31850|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 32006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32006&action=edit [SIGNED-OFF] Bug 12982 - Patron category dropdown empty in header search form on patron entry page The include file which contains the patron search form assumes that the page in which it is included will have access to a set of patron categories passed from the script. This is often not the case. This patch adds a new template plugin for getting patron categories and adds usage of it to patron-search.inc. The follow templates include patron-search.inc: members\boraccount.tt members\deletemem.tt members\files.tt members\mancredit.tt members\maninvoice.tt members\member-flags.tt members\member-password.tt members\member.tt members\memberentrygen.tt members\members-update.tt members\moremember.tt members\notices.tt members\pay.tt members\paycollect.tt members\purchase-suggestions.tt members\readingrec.tt members\routing-lists.tt members\statistics.tt tools\import_borrowers.tt tools\picture-upload.tt To test, view those pages and confirm that the patron category dropdown is present in the patron header search at the top of the page (shown by clicking the [+] link). Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12982 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Looks good. But I still have a question: Would this be the place to also provide the branches if they are not passed in? For instance, moremember now shows the Categories, but it still does not give me Libraries? I would not mind to pass QA on this patch, but if you want to include that now, please go ahead. Changing status to reflect need for clarification :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12982 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch fixes an issue, but also implements a way to get the patron categories through TT plugins. I think it has already been addressed by bug 7380. Feel free to report a new bug if the mentioned bug is already present for you (I didn't manage to reproduce it, on top of master/7380). *** This bug has been marked as a duplicate of bug 7380 *** -- You are receiving this mail because: You are watching all bug changes.