[Bug 22154] New: Subtype search for Format - Braille doesn't look for the right codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Bug ID: 22154 Summary: Subtype search for Format - Braille doesn't look for the right codes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com Target Milestone: --- When you do an advanced search and choose the Format subtype Braille, it looks for l-format:fk, but that is not the right code for Braille. To reproduce: 1) In Administration > System preferences, make sure 'Subtypes' is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions 2) Go in Advanced search 2.5) If necessary, click on 'More options' 3) In the 'Subtype limits' section, choose 'Braille' from the 'Format' drop-down menu 4) Click on 'Search' 5) In the breadcrumbs, it says 'Search with limit(s): 'l-format:fk'' fk does not exist. It should be fb for Tactile material/Braille OR tc for Text/Braille The codes for marc21 can be found here: http://www.loc.gov/marc/bibliographic/bd007f.html Thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87403&action=edit Bug 22154: Fix search for Braille from Advanced search page When you do an advanced search and choose the Format subtype Braille, it looks for l-format:fk, but that is not the right code for Braille. fk does not exist. It should be fb for Tactile material/Braille OR tc for Text/Braille To test: 0) Catalog 2 records, one with 007 tc and another with tb Use value builder to verify both are for Braille. 1) In Administration > System preferences, make sure 'Subtypes' is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions 2) Go to Advanced search 3) If necessary, click on 'More options' 4) In the 'Subtype limits' section, choose 'Braille' from the 'Format' drop-down menu 5) Click on 'Search' 6) Verify both records were found -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |testopia@bugs.koha-communit | |y.org Component|Searching - Zebra |Searching Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Michal Denar <black23@gmail.com> --- Hi, with ES I get: No results match your search with limit(s): 'ff7-01-02:tc or l-format:fb'. After full reindex. With Zebra I get just one result for search: for braile (tc) or large print (tb). Never both for brail. Same results in OPAC and staff client. Maybe I missed something. Some extra steps in test plan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Michal, I think with Elasticsearch that is another problem. Did you try if the other limits work with Elasticsearch as expected? The problem with the search lies in my test plan, I typoed with the codes. Braile is: tc or fb (not tb). I will upload a patch with an updated test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87403|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87945&action=edit Bug 22154: Fix search for Braille from Advanced search page When you do an advanced search and choose the Format subtype Braille, it looks for l-format:fk, but that is not the right code for Braille. fk does not exist. It should be fb for Tactile material/Braille OR tc for Text/Braille To test: 0) Catalog 2 records, one with 007 tc and another with fb Use value builder to verify both are for Braille. 1) In Administration > System preferences, make sure 'Subtypes' is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions 2) Go to Advanced search 3) If necessary, click on 'More options' 4) In the 'Subtype limits' section, choose 'Braille' from the 'Format' drop-down menu 5) Click on 'Search' 6) Verify both records were found -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87945|0 |1 is obsolete| | --- Comment #6 from Michal Denar <black23@gmail.com> --- Created attachment 87946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87946&action=edit Bug 22154: Fix search for Braille from Advanced search page When you do an advanced search and choose the Format subtype Braille, it looks for l-format:fk, but that is not the right code for Braille. fk does not exist. It should be fb for Tactile material/Braille OR tc for Text/Braille To test: 0) Catalog 2 records, one with 007 tc and another with fb Use value builder to verify both are for Braille. 1) In Administration > System preferences, make sure 'Subtypes' is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions 2) Go to Advanced search 3) If necessary, click on 'More options' 4) In the 'Subtype limits' section, choose 'Braille' from the 'Format' drop-down menu 5) Click on 'Search' 6) Verify both records were found Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 --- Comment #7 from Michal Denar <black23@gmail.com> --- ES problem reportetd as bug 22704. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87946|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 87969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87969&action=edit Bug 22154: Fix search for Braille from Advanced search page When you do an advanced search and choose the Format subtype Braille, it looks for l-format:fk, but that is not the right code for Braille. fk does not exist. It should be fb for Tactile material/Braille OR tc for Text/Braille To test: 0) Catalog 2 records, one with 007 tc and another with fb Use value builder to verify both are for Braille. 1) In Administration > System preferences, make sure 'Subtypes' is checked in either OpacAdvSearchMoreOptions or OpacAdvSearchOptions 2) Go to Advanced search 3) If necessary, click on 'More options' 4) In the 'Subtype limits' section, choose 'Braille' from the 'Format' drop-down menu 5) Click on 'Search' 6) Verify both records were found Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22154 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org