[Bug 15735] New: Audio Alerts editor broken by use of of single quotes in editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Bug ID: 15735 Summary: Audio Alerts editor broken by use of of single quotes in editor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Single quotes audio selector break ability to edit an alert -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15733 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 [Bug 15733] Audio Alerts issues in master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47622&action=edit Bug 15735 - Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47622|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47623&action=edit Bug 15735 - Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mirko@abunchofthings.net --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 [Bug 15734] Audio Alerts broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Mirko Tietgen from comment #3)
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc).
Forgot to mark this bug as dependent on 15734! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47623|0 |1 is obsolete| | --- Comment #5 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 47645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47645&action=edit [SIGNED-OFF]Bug 15735: Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Bug 15734 applied on top. Works as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47645|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47736&action=edit Bug 15735: Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Bug 15734 applied on top. Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |BLOCKED --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Blocked by 15734 being BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Bug 15735 depends on bug 15734, which changed state. Bug 15734 Summary: Audio Alerts broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47736|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48763&action=edit Bug 15735: Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Bug 15734 applied on top. Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15733 | Depends on|15734 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 [Bug 15733] Audio Alerts issues in master https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 [Bug 15734] Audio Alerts broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Brendan Gallagher <brendan@bywatersolutions.com> --- pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org