[Bug 21129] New: New ALTER IGNORE TABLE entries need correction in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Bug ID: 21129 Summary: New ALTER IGNORE TABLE entries need correction in updatedatabase.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: philippe.blouin@inlibro.com QA Contact: testopia@bugs.koha-community.org Bug 17234 made an effort to remove the ALTER IGNORE from updatedatabase.pl so that it could work with Mysql 5.7. But new entries have since been added to it: Bug 12395 - 18.06.00.005 Bug 19524 - 18.06.00.006 Bug 13560 - 18.06.00.008 These were oversights and must be removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |philippe.blouin@inlibro.com |ity.org | Priority|P5 - low |P3 Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 --- Comment #1 from Blou <philippe.blouin@inlibro.com> --- Created attachment 77313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77313&action=edit Bug 21129: New ALTER IGNORE TABLE entries need correction in updatedatabase.pl Bug 17234 made an effort to remove the ALTER IGNORE from updatedatabase.pl so that it could work with Mysql 5.7. But new entries have since been added to it: Bug 12395 - 18.06.00.005 Bug 19524 - 18.06.00.006 Bug 13560 - 18.06.00.008 This is corrected using column_exists to validate the existence of the new columns before ALTER -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12395, 19524, 13560 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 [Bug 12395] Save order line's creator https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 [Bug 13560] Add an 'Add' option in MARC modification templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 [Bug 19524] Share patron lists between staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 77313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77313 Bug 21129: New ALTER IGNORE TABLE entries need correction in updatedatabase.pl Review of attachment 77313: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21129&attachment=77313) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +16129,4 @@
$DBversion = '18.06.00.005'; if( CheckVersion( $DBversion ) ) { + unless ( column_exists('aqorders', 'created') ) {
It should be 'created_by' I think... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77313|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77330&action=edit Bug 21129: New ALTER IGNORE TABLE entries need correction in updatedatabase.pl Bug 17234 made an effort to remove the ALTER IGNORE from updatedatabase.pl so that it could work with Mysql 5.7. But new entries have since been added to it: Bug 12395 - 18.06.00.005 Bug 19524 - 18.06.00.006 Bug 13560 - 18.06.00.008 This is corrected using column_exists to validate the existence of the new columns before ALTER Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77331&action=edit Bug 21129: Fix typo created vs created_by -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77330|0 |1 is obsolete| | Attachment #77331|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 77360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77360&action=edit Bug 21129: New ALTER IGNORE TABLE entries need correction in updatedatabase.pl Bug 17234 made an effort to remove the ALTER IGNORE from updatedatabase.pl so that it could work with Mysql 5.7. But new entries have since been added to it: Bug 12395 - 18.06.00.005 Bug 19524 - 18.06.00.006 Bug 13560 - 18.06.00.008 This is corrected using column_exists to validate the existence of the new columns before ALTER Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 77361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77361&action=edit Bug 21129: Fix typo created vs created_by Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Bug 21129 depends on bug 19524, which changed state. Bug 19524 Summary: Share patron lists between staff https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master. Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Bug 21129 depends on bug 13560, which changed state. Bug 13560 Summary: Add an 'Add' option in MARC modification templates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Affected DB updates only exist in master branch, no need to apply to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org