https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16078 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Hi Owen, I found some references after applying the patch: git grep 'yuimenuitemlabel' 1 line in: installer/data/mysql/updatedatabase.pl git grep 'yui-button' 3 lines in: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/card-print.tt .yui-menu-button OK -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16078 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49173|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 49177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49177&action=edit Bug 16078 - Remove unused YUI CSS The YUI CSS file "skin.css" is no longer relevant to the staff client templates and can be removed. Other references to YUI-related classes, with the exception of grids, can also be removed. This patch removes references in CSS to: .yuimenuitemlabel .yui-button .yui-menu-button ...and removes the "yui-skin-sam" class from two templates' body tag. To test, apply the patch and clear your cache if necessary. Look around and confirm that the style of the staff client is unchanged. Search for references to the listed classes and confirm that none are found. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16078 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- I see one more place where "skin.css" is referenced, so I'll submit a follow-up. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16078 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49182&action=edit Bug 16078 [Follow-up] Remove unused YUI CSS skin.css is also included in a list of assets cached by the offline circulation page. It can be safely removed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16078 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #8)

Owen, There are 2 occurrences of skin.css left in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css

Whoops. I made a mistake when squashing some commits!

koha-tmpl/intranet-tmpl/prog/en/lib/yui/utilities/utilities.js

This file is only used by basketgroups.pl and as far as I can tell removing the CSS file has no affect on the functionality or style of that page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49177|0 |1 is obsolete| | Attachment #49189|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49220&action=edit Bug 16078 [Revised] Remove unused YUI CSS The YUI CSS file "skin.css" is no longer relevant to the staff client templates and can be removed. Other references to YUI-related classes, with the exception of grids, can also be removed. This patch removes references in CSS to: .yuimenuitemlabel .yui-button .yui-menu-button ...and removes the "yui-skin-sam" class from two templates' body tag. skin.css is also included in a list of assets cached by the offline circulation page. It can be safely removed. To test, apply the patch and clear your cache if necessary. Look around and confirm that the style of the staff client is unchanged. Search for references to the listed classes and confirm that none are found. Revised patch squashes in the follow-up as well as a missing commit removing skin.css from staff-global.css. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16078 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16078 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49222|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49250&action=edit Bug 16078 [Revised] Remove unused YUI CSS The YUI CSS file "skin.css" is no longer relevant to the staff client templates and can be removed. Other references to YUI-related classes, with the exception of grids, can also be removed. This patch removes references in CSS to: .yuimenuitemlabel .yui-button .yui-menu-button ...and removes the "yui-skin-sam" class from two templates' body tag. skin.css is also included in a list of assets cached by the offline circulation page. It can be safely removed. To test, apply the patch and clear your cache if necessary. Look around and confirm that the style of the staff client is unchanged. Search for references to the listed classes and confirm that none are found. Revised patch squashes in the follow-up as well as a missing commit removing skin.css from staff-global.css. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.