[Bug 6096] New: GetAllShelves has obfuscated return type
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6096 Bug #: 6096 Summary: GetAllShelves has obfuscated return type Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 Component: Virtual Shelves AssignedTo: colin.campbell@ptfs-europe.com ReportedBy: colin.campbell@ptfs-europe.com QAContact: koha-bugs@lists.koha-community.org GetAllShelves suffers from the same problem as caused bug 5529 the scalar return of the db fetchall_arrayref is stored in an array. Not surprising the calling code is outputting debug code!! Refactor the routine to do what we think it is correct -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6096 --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-04-06 15:37:13 UTC --- Created attachment 3755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3755 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6096 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Severity|enhancement |normal -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6096 Frederic Durand <frederic.durand@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic.durand@univ-lyon2. | |fr Patch Status|Needs Signoff |Signed Off --- Comment #2 from Frederic Durand <frederic.durand@univ-lyon2.fr> 2011-04-07 15:30:46 UTC --- Everything looks ok. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6096 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-07 23:19:09 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org