http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #2 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Created attachment 10569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10569&action=edit patch to add longoverdue syspref -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Version|3.8 |master --- Comment #4 from Maxime Pelletier <pelletiermaxime@gmail.com> --- This still applies to master, so switched to needs signoff. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Leila and Fridos help <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16810&action=edit Bug 8337 System preferences for longoverdue cron Patch to follow that adds 3 new system preferences to control the parameters for the longoverdue script. New prefs are DefaultLongOverdueChargeValue, DefaultLongOverdueLostValue and DefaultLongOverdueDays. These preferences are used when you call the longoverdue.pl script without their parameters. Sponsored-By: CCSR Signed-off-by: Leila and Fridos help <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Didn't test the patch, but the 3 syspref are not added to updatedatabase.pl and sysprefs.sql Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #12 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 30639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30639&action=edit Bug 8337 - Added the sysprefs to the database scripts. modified: installer/data/mysql/sysprefs.sql modified: installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de, | |kyle@bywatersolutions.com --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Starting with a code review: 1) (trivial) The QA script has some complaints about those patches: FAIL installer/data/mysql/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs defaultlongoverduechargevalue is bad placed (see bug 10610) FAIL installer/data/mysql/updatedatabase.pl OK critic FAIL pod *** WARNING: =head2 without preceding higher level in file installer/data/mysql/updatedatabase.pl OK valid OK forbidden patterns 2) (trivial) Database update should include the bug number for later reference. 3) (normal) The database update and sysprefs.sql use all lowercaps system preference names, but the pref file and the longoerdue.pl use camel case. 4) (just a question) I took a look at our crontab example file and the cronjob is commented out with parameters and in debian/koha-common.cron.daily the cronjob is missing. Should we adapt those? Please provide a follow-up and switch back to Signed-off. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #14 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 30944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30944&action=edit Bug 8337 - Follow-up to Comment 13 Fixed QA script issues. Syspref names are now camelcased. Bug number added in updatedatabase.pl . If the cronjob is deactivated by default, shouldn't we leave it like that? Bear in mind that I am not an expert. modified: installer/data/mysql/sysprefs.sql modified: installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- I don't understand the usefulness of these 3 sysprefs. I know everybody loves sysprefs but do you have another argument? The longoverdue script is a cronjob and if you want to call this script with "default parameters" you just have to set them in the crontab. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Blou from comment #16)

These prefs are the whole objective of this patch: allow the librarian to set things up without having to rely on IT people.

If we increase the number of sysprefs, we may end up relying even more on IT people :) Looking at your argument, I would agree with Jonathan: You only have to put the correct arguments once (or very incidentally) in your crontab. No need for extra sysprefs. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 Anthony Laquerre <anthony.laquerre@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anthony.laquerre@ccsr.qc.ca --- Comment #19 from Anthony Laquerre <anthony.laquerre@ccsr.qc.ca> --- I jump in the conversation since we are the schools consortia that initially create the ticket. In a context of school library systems such preferences are likely to change on average 2-3 times per year. Unfortulalty, many library does not have the money available to make requests for changes to IT company. Unlike Jonathan, I beleive that each cronjob parameter useful for the end user should be in the sys pref table. This allows the librarian to make his own choix and not always having to go through a process of change by the IT provider. I understand that right now there is a lot of parameters but this is also one the of biggest strenght of Koha ! Hard to start but once you understand how every sys pref work you can do anything you want. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simith.doliveira@inlibro.co | |m Assignee|maxime.beaulieu@inlibro.com |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #22 from Blou <philippe.blouin@inlibro.com> --- You extrapolate, here. We're not talking about every script, nor about every argument of every script. Technicaly, there are no constraint on the number of prefs we can handle. There were 10, then 200 and there'll be 2000. Having the right nomenclature to identify them could be a big plus, but that is true for every pref already in the DB, imo. Now, if we go back to the need of the user, "configurable" cron job is a need. Specifically for this cronjob. And this seems like something other users would benefit from. With no impact. (THere are alternatives, but they do have impact, and it's outside this small scope) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #23 from Jesse Weaver <jweaver@bywatersolutions.com> --- I have some ideas related to this, though implementation is a bit stalled at the moment. My plans were for a configuration system outside of the system preferences, which could potentially replace all daily tasks in the crontab with: 0 1 * * * $KOHA_CRON_PATH/misc/cronjobs/run_daily_tasks.pl and a matching database structure to hold information on enabled/disabled cronjobs and all of their selected options (including metadata, somewhere, on what options were available for each and what values they took). This cronjob would load up all enabled cronjobs, figure out what dependency order they had to be executed in, then run them in series. There was also some thought for a built-in output logging facility. Note that I don't have any plans to modify the cronjobs in question; they would still be run as external scripts, just with options built up from the configuration in the database. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #27 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 32290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32290&action=edit Bug 8337 - Added prefs to sysprefs and updatedatabase Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #29 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 32292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32292&action=edit Bug 8337: Small typo in usage statement for longoverdue.pl The charge with the replacement price will only be made if the charge parameter matches the lost value. The given example is faulty (as well as some of the code, as it appears ;) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Frederik and Maxime! -- You are receiving this mail because: You are watching all bug changes.