[Bug 44088] New: Notices management: hide and disable printing of SHARE_INVITE content
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44088 Bug ID: 44088 Summary: Notices management: hide and disable printing of SHARE_INVITE content Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk Depends on: 33260 Target Milestone: --- Follow-up to bug 33260, reported by Pedro Amorim. SHARE_INVITE contains a secret too: its link carries the invitation key for a private list, and anyone with that link can accept the share and read the list. Unlike PASSWORD_RESET, STAFF_PASSWORD_RESET, OPAC_REG_VERIFY and 2FA_OTP_TOKEN, its content is shown and printable in Notices management. The SHARE_INVITE content should be hidden and not printable, like the other secret-bearing notices. Test plan: 1) Set 'NoticesManagement' to 'Enable' and 'OpacAllowSharingPrivateLists' to 'Allow' 2) Log in to the OPAC as koha/koha (http://localhost:8080) 3) Click 'Lists' > 'Your lists' > 'New list', name 'My list', keep 'Private', click 'Save' (http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=add_form) 4) Click 'Lists' > 'Your lists', click the 'Share' link next to 'My list', enter 'friend@example.com' and click 'Send' (http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=list) 5) In a KTD shell, run: perl misc/cronjobs/process_message_queue.pl KTD has no mail server, so it prints an SMTP error and the invitation is now 'failed' 6) In the staff interface, go to 'More' > 'Tools' > 'Notices management' (http://localhost:8081/cgi-bin/koha/tools/notices.pl) 7) Click the subject 'Share list My list' 8) Confirm the preview shows the invitation link with its key, and the notice has a 'Print' button Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 [Bug 33260] Show message queue on staff interface and make notices printable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44088 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 211539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211539&action=edit Bug 44088: Hide and disable printing of SHARE_INVITE content in Notices management SHARE_INVITE contains a secret: its link carries the invitation key for a private list, and anyone with that link can accept the share and read the list. Unlike PASSWORD_RESET, STAFF_PASSWORD_RESET, OPAC_REG_VERIFY and 2FA_OTP_TOKEN, its content was shown and printable in Notices management. Add SHARE_INVITE to the list of sensitive letter codes. To test: 1. Set 'NoticesManagement' to 'Enable' and 'OpacAllowSharingPrivateLists' to 'Allow' 2. Log in to the OPAC as koha/koha 3. Create a private list, then share it with friend@example.com 4. In a KTD shell, run: perl misc/cronjobs/process_message_queue.pl (KTD has no mail server, so the invitation is now 'failed') 5. Go to More > Tools > Notices management and click the subject 'Share list My list' 6. Without the patch the preview shows the invitation link with its key and a 'Print' button 7. Apply the patch, run restart_all and reload 8. Confirm the content is not displayed and there is no 'Print' button 9. Run: prove t/db_dependent/Koha/Notice/Message.t 10. Run: yarn cypress run --spec t/cypress/integration/Tools/NoticesManagement_spec.ts Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44088 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44088 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44088 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44088 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44088 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #211539|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44088 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 211558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211558&action=edit Bug 44088: Hide and disable printing of SHARE_INVITE content in Notices management SHARE_INVITE contains a secret: its link carries the invitation key for a private list, and anyone with that link can accept the share and read the list. Unlike PASSWORD_RESET, STAFF_PASSWORD_RESET, OPAC_REG_VERIFY and 2FA_OTP_TOKEN, its content was shown and printable in Notices management. Add SHARE_INVITE to the list of sensitive letter codes. To test: 1. Set 'NoticesManagement' to 'Enable' and 'OpacAllowSharingPrivateLists' to 'Allow' 2. Log in to the OPAC as koha/koha 3. Create a private list, then share it with friend@example.com 4. In a KTD shell, run: perl misc/cronjobs/process_message_queue.pl (KTD has no mail server, so the invitation is now 'failed') 5. Go to More > Tools > Notices management and click the subject 'Share list My list' 6. Without the patch the preview shows the invitation link with its key and a 'Print' button 7. Apply the patch, run restart_all and reload 8. Confirm the content is not displayed and there is no 'Print' button 9. Run: prove t/db_dependent/Koha/Notice/Message.t 10. Run: yarn cypress run --spec t/cypress/integration/Tools/NoticesManagement_spec.ts Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44088 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Step 3: Add some items to list you created, then the menu/toolbar comes up so that you can share it. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org