[Bug 18950] New: Elasticsearch - Add password access for admin functions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18950 Bug ID: 18950 Summary: Elasticsearch - Add password access for admin functions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: nick@bywatersolutions.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org This patchset adds a parameter to the koha-conf.xml file: <elasticsearch_admin_password> When defined additional actions will be enabled on the Search engine configuration page Password must be entered and action chosen, if password matches the action will be performed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18950 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18950 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65088&action=edit Bug 18950 - Elasticsearch - Add password access for admin functions To test: 1 - Load 'Search engine configuration' from admin page http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings... 2 - Verify this works as before the patch 3 - Add <elasticsearch_admin_password> to koha-conf.xml 4 - Reload search config page, note additional option to reset mappings 5 - Attempt reset with bad password 6 - Attempt reset with correct password Note: the action is a drop down as reindexing will be added, however, code needs some refactoring before this option can be implemented -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18950 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18950 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18948 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18948 [Bug 18948] Elasticsearch - Reindexes should use aliases to avoid down time while reindexing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18950 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65088|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65160&action=edit Bug 18950 - Elasticsearch - Add password access for admin functions To test: 1 - Load 'Search engine configuration' from admin page http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings... 2 - Verify this works as before the patch 3 - Add <elasticsearch_admin_password> to koha-conf.xml 4 - Reload search config page, note additional option to reset mappings 5 - Attempt reset with bad password 6 - Attempt reset with correct password 7 - Attempt a reindex with bad password 8 - Attempt a reindex with correct password -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18950 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching |Searching - Elasticsearch QA Contact|testopia@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18950 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david.bourgault@inlibro.com --- Comment #3 from David Bourgault <david.bourgault@inlibro.com> --- Patch applies, and basic functionality is there, however: - "Reindex" checked for password correctly but failed since 18948 does not apply for me (not an issue, just a note) - The password input field is of type=text but should be of type=password - The error message when you enter a wrong password should probably more obvious (like being red, or using the standard koha warning boxes) - I'd suggest moving the <elasticsearch_admin_password> XML node inside the <elasticsearch> group, seems cleaner to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18950 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|nick@bywatersolutions.com |koha-bugs@lists.koha-commun | |ity.org --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Not working on this one -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18950 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18950 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org