[Bug 37109] New: Don't provide old claims fields when duplicating acquisitions orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Bug ID: 37109 Summary: Don't provide old claims fields when duplicating acquisitions orders Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org The following fields that used to be in the aqorders table for claims are still initialised when duplicating orders. They aren't stored anywhere so don't cause a problem, but they don't need to be set at all. * claims_count (dropped in Bug 24161) * claimed_date (dropped in Bug 24161) * placed_on (no evidence of this field existing in aqorders) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24161 Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 [Bug 24161] Add ability to track the claim dates of later orders -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167816&action=edit Bug 37109: Don't initialise claims fields when duplicating acquisitions orders These fields don't exist in the aqorders table and don't need to be set/passed on. To test: 1. Go to Acquisitions 2. Create a vendor if you don't already have one 3. Create a basket if you don't already have one 4. Add an order to the basket and Save 5. Add another order to the basket, choose "From existing orders (copy)" 6. Continue through the process and confirm you're able to duplicate the order as normal 7. Confirm tests still pass t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167816|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 167817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167817&action=edit Bug 37109: Don't initialise claims fields when duplicating acquisitions orders These fields don't exist in the aqorders table and don't need to be set/passed on. * claims_count (dropped in Bug 24161) * claimed_date (dropped in Bug 24161) * placed_on (no evidence of this field existing in aqorders) * received_on (no evidence of this field existing in aqorders) To test: 1. Go to Acquisitions 2. Create a vendor if you don't already have one 3. Create a basket if you don't already have one 4. Add an order to the basket and Save 5. Add another order to the basket, choose "From existing orders (copy)" 6. Continue through the process and confirm you're able to duplicate the order as normal 7. Confirm tests still pass t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 [Bug 27063] Allow changing which record an order is linked to -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167817|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167822&action=edit Bug 37109: Don't initialise claims fields when duplicating acquisitions orders These fields don't exist in the aqorders table and don't need to be set/passed on. * claims_count (dropped in Bug 24161) * claimed_date (dropped in Bug 24161) * placed_on (no evidence of this field existing in aqorders) * received_on (no evidence of this field existing in aqorders) To test: 1. Go to Acquisitions 2. Create a vendor if you don't already have one 3. Create a basket if you don't already have one 4. Add an order to the basket and Save 5. Add another order to the basket, choose "From existing orders (copy)" 6. Continue through the process and confirm you're able to duplicate the order as normal 7. Confirm tests still pass t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27063 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 [Bug 27063] Allow changing which record an order is linked to -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27063 [Bug 27063] Allow changing which record an order is linked to -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167822|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 172493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172493&action=edit Bug 37109: Don't initialise claims fields when duplicating acquisitions orders These fields don't exist in the aqorders table and don't need to be set/passed on. * claims_count (dropped in Bug 24161) * claimed_date (dropped in Bug 24161) * placed_on (no evidence of this field existing in aqorders) * received_on (no evidence of this field existing in aqorders) To test: 1. Go to Acquisitions 2. Create a vendor if you don't already have one 3. Create a basket if you don't already have one 4. Add an order to the basket and Save 5. Add another order to the basket, choose "From existing orders (copy)" 6. Continue through the process and confirm you're able to duplicate the order as normal 7. Confirm tests still pass t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think placed_on refers to aqorders.creationdate and received_on to datereceived, but at the same time you would not want to duplicate these. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch stops the unused release notes| |fields claims_count, | |claimed_date, received_on | |and placed_on from being | |initialised while | |duplicating an order. The | |fields no longer exist in | |the aqorders table and no | |longer need to be set or | |passed on. Keywords|release-notes-needed | CC| |philip.orr@lmscloud.de --- Comment #7 from Philip Orr <philip.orr@lmscloud.de> --- release notes added -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37109 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org